Skip to content

fix(reports): preserve application counts and threat (#855) - #867

Merged
daniel-grnbn merged 2 commits into
b02/854-agent-anonymizationfrom
b02/855-application-counts
Nov 19, 2026
Merged

daniel-grnbn merged 2 commits into
b02/854-agent-anonymizationfrom
b02/855-application-counts

Conversation

@hive-bumblebee

@hive-bumblebee hive-bumblebee commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Preserve application hosts_count, occurrences and threat while leaving server-calculated severity unchanged. Cover Agent-derived results, absent/empty/zero and malformed counts.

Closes #855.

Stack — 9 of 11

Base: #865 (b02/854-agent-anonymization). Next: #866. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.

#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868

Verification

  • Exact head: a25d5ba4a314db4c62768da420462e4f607c2e68.
  • CI for this exact head — dispatched after review-fix propagation; current result: in_progress.
  • Complete stack tip b6f33da1224aa4950f39dc3db0e6d5607e0e0f89: 1,634 tests passed across 128 targets, zero failures, one pre-existing ignored doctest. Command: cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests,gvm-gmp/serde.
  • Strict workspace/all-target Clippy with those socket/serde features, formatting and diff checks passed locally. Canonical inventory tests remain passing.
  • Full-feature/stable/MSRV/coverage/documentation/python-gvm checks are tracked by the linked CI; local qualification is not a claim they have already passed.
  • No live gvmd, LDAP, signer, Agent Controller scheduling, or real support-bundle privacy/cryptography qualification. See feature/mock contract.

Agent: b02-agent-035

@hive-bumblebee
hive-bumblebee requested review from a team as code owners November 18, 2026 21:15
@hive-bumblebee
hive-bumblebee force-pushed the b02/855-application-counts branch from a5bc98b to ddf1556 Compare November 18, 2026 21:18
clawosiris
clawosiris previously approved these changes Nov 19, 2026

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head c8d0c5ae6dcbce3264124b45a3e829d26dfa9985 against stacked base 85d0d7624bd05314e01bf4146db59d8cee42152c.

Two independent evidence-gated passes reviewed only this stack slice. Host/occurrence counts preserve absent, empty, zero, and malformed distinctions; server severity/threat are retained without recomputation; legacy optional ID/serde behavior remains compatible. Exact-head CI is green. No findings remained.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn added this pull request to stack #870 November 19, 2026 11:31

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head a25d5ba against immediate stack base 54222bb.

Reviewed report application counts, threat metadata, and absent identifiers, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn merged commit 0afc311 into main Nov 19, 2026
53 checks passed
@daniel-grnbn
daniel-grnbn deleted the b02/855-application-counts branch November 19, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve application occurrence and host counts

3 participants