Repository navigation
fix(agents): preserve operating-system metadata (#853) - #864
Conversation
deea892 to
ba35474
Compare
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head ba354745a996f6097e8ebe4bd1073d4bb862ff4a against stacked base b703fdf0d361a188b1cead918e70f543cd6a8fe6.
Two independent evidence-gated passes reviewed only this stack slice. All four gvmd OS metadata fields map correctly; absent, empty, and whitespace-only values remain None; older serde payloads remain readable. Focused tests and exact-head CI are green. No findings remained.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head 3ddccf5 against immediate stack base d874b03.
Reviewed agent operating-system metadata decoding, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
Summary
Preserve operating_system, architecture, os_cpe and os_status in typed agent responses. Independent fixtures cover populated, absent and empty values.
Closes #853.
Stack — 7 of 11
Base: #863 (
b02/852-inventory-token). Next: #865. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868
Verification
3ddccf57ea49c36fc70a508d94820995eb9cde8f.b6f33da1224aa4950f39dc3db0e6d5607e0e0f89: 1,634 tests passed across 128 targets, zero failures, one pre-existing ignored doctest. Command:cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests,gvm-gmp/serde.Agent: b02-agent-035