Skip to content

fix(agents): preserve operating-system metadata (#853) - #864

Merged
daniel-grnbn merged 2 commits into
b02/852-inventory-tokenfrom
b02/853-agent-os-metadata
Nov 19, 2026
Merged

daniel-grnbn merged 2 commits into
b02/852-inventory-tokenfrom
b02/853-agent-os-metadata

Conversation

@hive-bumblebee

@hive-bumblebee hive-bumblebee commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Preserve operating_system, architecture, os_cpe and os_status in typed agent responses. Independent fixtures cover populated, absent and empty values.

Closes #853.

Stack — 7 of 11

Base: #863 (b02/852-inventory-token). Next: #865. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.

#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868

Verification

  • Exact head: 3ddccf57ea49c36fc70a508d94820995eb9cde8f.
  • CI for this exact head — dispatched after review-fix propagation; current result: in_progress.
  • Complete stack tip b6f33da1224aa4950f39dc3db0e6d5607e0e0f89: 1,634 tests passed across 128 targets, zero failures, one pre-existing ignored doctest. Command: cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests,gvm-gmp/serde.
  • Strict workspace/all-target Clippy with those socket/serde features, formatting and diff checks passed locally. Canonical inventory tests remain passing.
  • Full-feature/stable/MSRV/coverage/documentation/python-gvm checks are tracked by the linked CI; local qualification is not a claim they have already passed.
  • No live gvmd, LDAP, signer, Agent Controller scheduling, or real support-bundle privacy/cryptography qualification. See feature/mock contract.

Agent: b02-agent-035

@hive-bumblebee
hive-bumblebee requested review from a team as code owners November 18, 2026 21:14
clawosiris
clawosiris previously approved these changes Nov 19, 2026

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head ba354745a996f6097e8ebe4bd1073d4bb862ff4a against stacked base b703fdf0d361a188b1cead918e70f543cd6a8fe6.

Two independent evidence-gated passes reviewed only this stack slice. All four gvmd OS metadata fields map correctly; absent, empty, and whitespace-only values remain None; older serde payloads remain readable. Focused tests and exact-head CI are green. No findings remained.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn added this pull request to stack #870 November 19, 2026 11:31

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 3ddccf5 against immediate stack base d874b03.

Reviewed agent operating-system metadata decoding, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn merged commit 4ff5256 into main Nov 19, 2026
53 checks passed
@daniel-grnbn
daniel-grnbn deleted the b02/853-agent-os-metadata branch November 19, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve agent operating-system metadata

3 participants