Skip to content

feat(gmp): preserve result VT type discriminator - #858

Merged
daniel-grnbn merged 4 commits into
b02/849-target-provenancefrom
b02/856-result-vt-type
Nov 19, 2026
Merged

daniel-grnbn merged 4 commits into
b02/849-target-provenancefrom
b02/856-result-vt-type

Conversation

@hive-bumblebee

@hive-bumblebee hive-bumblebee commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Preserve optional result-NVT type alongside unchanged type_metadata, including unknown future values and older responses. Update realistic fixtures/stateful projections and serde regression coverage.

Closes #856.

Stack — 3 of 11

Base: #862 (b02/849-target-provenance). Next: #859. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.

#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868

Verification

  • Exact head: 0d3651d2058bd960e30d16f958c107b1b2dac22b.
  • Full CI for this exact head — the linked run is the source of truth for its current status; explicitly dispatched for stacked bases where necessary.
  • Complete 11-slice tip 096cea01e402514e27960fb002835e3aa661679d: 1,611 tests passed across 125 targets, zero failures, one pre-existing ignored doctest. Command: cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests.
  • Combined strict workspace/all-target Clippy with the same socket-test features, formatting and diff checks passed locally. Canonical inventories verify 1,045 classified rows and 270 typed helpers.
  • Full-feature/stable/MSRV/coverage/documentation/python-gvm qualification is recorded in the linked CI. No live gvmd, LDAP or Agent Controller qualification is claimed.

Agent: b02-agent-035

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 0d3651d2058bd960e30d16f958c107b1b2dac22b against stacked base 315dc82340c4b868b2675fa52fb9806e846923d3.

Two independent evidence-gated passes reviewed only this stack slice. The optional discriminator is lossless for known and future values, absence remains None, legacy serde remains readable, and type_metadata is unchanged. Focused parser/mock tests and exact-head CI are green. No findings remained.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn added this pull request to stack #870 November 19, 2026 11:31

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 0d3651d against immediate stack base 315dc82.

Reviewed open-vocabulary NVT type and opaque metadata preservation, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn merged commit 5d0193f into main Nov 19, 2026
53 checks passed
@daniel-grnbn
daniel-grnbn deleted the b02/856-result-vt-type branch November 19, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve the result-NVT type discriminator alongside type_metadata

3 participants