Repository navigation
feat(gmp): preserve result VT type discriminator - #858
Conversation
faf63c8 to
0d3651d
Compare
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head 0d3651d2058bd960e30d16f958c107b1b2dac22b against stacked base 315dc82340c4b868b2675fa52fb9806e846923d3.
Two independent evidence-gated passes reviewed only this stack slice. The optional discriminator is lossless for known and future values, absence remains None, legacy serde remains readable, and type_metadata is unchanged. Focused parser/mock tests and exact-head CI are green. No findings remained.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head 0d3651d against immediate stack base 315dc82.
Reviewed open-vocabulary NVT type and opaque metadata preservation, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
Summary
Preserve optional result-NVT type alongside unchanged type_metadata, including unknown future values and older responses. Update realistic fixtures/stateful projections and serde regression coverage.
Closes #856.
Stack — 3 of 11
Base: #862 (
b02/849-target-provenance). Next: #859. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868
Verification
0d3651d2058bd960e30d16f958c107b1b2dac22b.096cea01e402514e27960fb002835e3aa661679d: 1,611 tests passed across 125 targets, zero failures, one pre-existing ignored doctest. Command:cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests.Agent: b02-agent-035