Skip to content

feat(gmp): preserve target source provenance - #862

Merged
daniel-grnbn merged 1 commit into
b02/850-sensor-port-zerofrom
b02/849-target-provenance
Nov 19, 2026
Merged

daniel-grnbn merged 1 commit into
b02/850-sensor-port-zerofrom
b02/849-target-provenance

Conversation

@hive-bumblebee

@hive-bumblebee hive-bumblebee commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add optional validated target source to create/modify, preserve absent and unknown response provenance, and cover defaults, copying, source filters and atomic updates. Older serialized targets remain readable.

Closes #849.

Stack — 2 of 11

Base: #860 (b02/850-sensor-port-zero). Next: #858. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.

#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868

Verification

  • Exact head: 315dc82340c4b868b2675fa52fb9806e846923d3.
  • Full CI for this exact head — the linked run is the source of truth for its current status; explicitly dispatched for stacked bases where necessary.
  • Complete 11-slice tip 096cea01e402514e27960fb002835e3aa661679d: 1,611 tests passed across 125 targets, zero failures, one pre-existing ignored doctest. Command: cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests.
  • Combined strict workspace/all-target Clippy with the same socket-test features, formatting and diff checks passed locally. Canonical inventories verify 1,045 classified rows and 270 typed helpers.
  • Full-feature/stable/MSRV/coverage/documentation/python-gvm qualification is recorded in the linked CI. No live gvmd, LDAP or Agent Controller qualification is claimed.

Agent: b02-agent-035

@hive-bumblebee
hive-bumblebee requested review from a team as code owners November 18, 2026 21:12
@hive-bumblebee
hive-bumblebee force-pushed the b02/849-target-provenance branch from 566f0cd to 9b39a1c Compare November 18, 2026 21:14

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 315dc82340c4b868b2675fa52fb9806e846923d3 against stacked base c6b04d346f056987b332ae35219538c05ae7f2c6.

Two independent evidence-gated passes reviewed only this stack slice. Target-source create/modify validation, omission/default semantics, lossless response handling, copy/filter behavior, mock atomicity, and regressions match issue #849 and pinned gvmd behavior. Exact-head CI is green. No blocking or advisory findings remained.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn added this pull request to stack #870 November 19, 2026 11:31

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 315dc82 against immediate stack base c6b04d3.

Reviewed typed target source handling, stateful persistence and atomic-update regressions, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn merged commit 8ad3e18 into main Nov 19, 2026
33 checks passed
@daniel-grnbn
daniel-grnbn deleted the b02/849-target-provenance branch November 19, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Preserve target source provenance

3 participants