Repository navigation
feat(gmp): preserve target source provenance - #862
Conversation
566f0cd to
9b39a1c
Compare
9b39a1c to
315dc82
Compare
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head 315dc82340c4b868b2675fa52fb9806e846923d3 against stacked base c6b04d346f056987b332ae35219538c05ae7f2c6.
Two independent evidence-gated passes reviewed only this stack slice. Target-source create/modify validation, omission/default semantics, lossless response handling, copy/filter behavior, mock atomicity, and regressions match issue #849 and pinned gvmd behavior. Exact-head CI is green. No blocking or advisory findings remained.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head 315dc82 against immediate stack base c6b04d3.
Reviewed typed target source handling, stateful persistence and atomic-update regressions, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
Summary
Add optional validated target source to create/modify, preserve absent and unknown response provenance, and cover defaults, copying, source filters and atomic updates. Older serialized targets remain readable.
Closes #849.
Stack — 2 of 11
Base: #860 (
b02/850-sensor-port-zero). Next: #858. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868
Verification
315dc82340c4b868b2675fa52fb9806e846923d3.096cea01e402514e27960fb002835e3aa661679d: 1,611 tests passed across 125 targets, zero failures, one pre-existing ignored doctest. Command:cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests.Agent: b02-agent-035