Repository navigation
feat(gmp): preserve structured report task scan config - #859
Conversation
4c16023 to
5b095bb
Compare
5b095bb to
a62b9d5
Compare
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head a62b9d5f6d04707cbbce47c6d85e7aa03915d3a4 against stacked base 0d3651d2058bd960e30d16f958c107b1b2dac22b.
Two independent evidence-gated passes reviewed only this stack slice. The shared scan/audit decoder preserves optional scan-config UUID/name without synthesis, keeps existing task fields intact, and remains compatible with older XML/serde payloads. Exact-head CI is green. No findings remained.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
clawosiris
left a comment
There was a problem hiding this comment.
Approved at exact head a62b9d5 against immediate stack base 0d3651d.
Reviewed structured scan and audit report configuration references, the relevant regression coverage, merge/restack resolution where applicable, and exact-head CI. No blocking findings.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
Summary
Preserve optional scan_config UUID/name in the shared scan/audit report task decoder, including config-less and older payloads. Update mock output and regression coverage without fetching substitute client-side data.
Closes #857.
Stack — 4 of 11
Base: #858 (
b02/856-result-vt-type). Next: #861. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868
Verification
a62b9d5f6d04707cbbce47c6d85e7aa03915d3a4.096cea01e402514e27960fb002835e3aa661679d: 1,611 tests passed across 125 targets, zero failures, one pre-existing ignored doctest. Command:cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests.Agent: b02-agent-035