Repository navigation
fix(gmp): support sensor scanner port zero - #860
Merged
Merged
Conversation
This was referenced Nov 18, 2026
clawosiris
approved these changes
Nov 19, 2026
clawosiris
left a comment
Collaborator
There was a problem hiding this comment.
Approved at exact head c6b04d346f056987b332ae35219538c05ae7f2c6 against base 125e16fffe7b1a8ed01a00caa2c15f2e974eda09.
Two independent evidence-gated passes reviewed only this stack slice. The sensor-port validation, omitted-type server validation, mock normalization/atomicity, relay-port separation, and focused regressions match issue #850 and the pinned gvmd behavior. Exact-head CI and Security checks are green. No blocking or advisory findings remained.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept sensor port zero in canonical requests, defer omitted-type update validation to gvmd, and retain ordinary scanner/network relay rules. Align mock normalization and atomic type-change behavior with current gvmd, including both transition directions.
Closes #850.
Stack — 1 of 11
Base:
main(main). Next: #862. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868
Verification
c6b04d346f056987b332ae35219538c05ae7f2c6.096cea01e402514e27960fb002835e3aa661679d: 1,611 tests passed across 125 targets, zero failures, one pre-existing ignored doctest. Command:cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests.Agent: b02-agent-035