Skip to content

fix(gmp): support sensor scanner port zero - #860

Merged
daniel-grnbn merged 4 commits into
mainfrom
b02/850-sensor-port-zero
Nov 19, 2026
Merged

daniel-grnbn merged 4 commits into
mainfrom
b02/850-sensor-port-zero

Conversation

@hive-bumblebee

@hive-bumblebee hive-bumblebee commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Accept sensor port zero in canonical requests, defer omitted-type update validation to gvmd, and retain ordinary scanner/network relay rules. Align mock normalization and atomic type-change behavior with current gvmd, including both transition directions.

Closes #850.

Stack — 1 of 11

Base: main (main). Next: #862. Review against the base branch; land bottom-up and retarget/rebase as earlier layers land. No automatic merges enabled.

#860 → #862 → #858 → #859 → #861 → #863 → #864 → #865 → #867 → #866 → #868

Verification

  • Exact head: c6b04d346f056987b332ae35219538c05ae7f2c6.
  • Full CI for this exact head — the linked run is the source of truth for its current status; explicitly dispatched for stacked bases where necessary.
  • Complete 11-slice tip 096cea01e402514e27960fb002835e3aa661679d: 1,611 tests passed across 125 targets, zero failures, one pre-existing ignored doctest. Command: cargo test --workspace --features gvm-client/unix-socket-tests,gvm-mock-server/unix-socket-tests.
  • Combined strict workspace/all-target Clippy with the same socket-test features, formatting and diff checks passed locally. Canonical inventories verify 1,045 classified rows and 270 typed helpers.
  • Full-feature/stable/MSRV/coverage/documentation/python-gvm qualification is recorded in the linked CI. No live gvmd, LDAP or Agent Controller qualification is claimed.

Agent: b02-agent-035

@hive-bumblebee
hive-bumblebee requested review from a team as code owners November 18, 2026 21:07

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head c6b04d346f056987b332ae35219538c05ae7f2c6 against base 125e16fffe7b1a8ed01a00caa2c15f2e974eda09.

Two independent evidence-gated passes reviewed only this stack slice. The sensor-port validation, omitted-type server validation, mock normalization/atomicity, relay-port separation, and focused regressions match issue #850 and the pinned gvmd behavior. Exact-head CI and Security checks are green. No blocking or advisory findings remained.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

@daniel-grnbn
daniel-grnbn added this pull request to stack #870 November 19, 2026 11:31
@daniel-grnbn
daniel-grnbn merged commit 458d878 into main Nov 19, 2026
27 of 29 checks passed
@daniel-grnbn
daniel-grnbn deleted the b02/850-sensor-port-zero branch November 19, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: allow gvmd sensor scanner port zero in canonical requests

3 participants