Skip to content

MNT: List optional dependencies and test in CI - #125

Merged
arokem merged 1 commit into
tee-ar-ex:masterfrom
jhlegarreta:mnt/list-optional-deps
Aug 11, 2026
Merged

MNT: List optional dependencies and test in CI#125
arokem merged 1 commit into
tee-ar-ex:masterfrom
jhlegarreta:mnt/list-optional-deps

Conversation

@jhlegarreta

Copy link
Copy Markdown
Contributor

List optional dependencies and add a job to the CI workflows so that the related tests are run.

Install the optional dependencies in the coverage workflow CI so that a faithful coverage is reported.

@jhlegarreta
jhlegarreta force-pushed the mnt/list-optional-deps branch 2 times, most recently from 81d1dc4 to 4a1f230 Compare August 11, 2026 07:02
List optional dependencies and add a job to the CI workflows so that the
related tests are run.

Install the optional dependencies in the coverage workflow CI so that a
faithful coverage is reported.
@jhlegarreta
jhlegarreta force-pushed the mnt/list-optional-deps branch from 4a1f230 to e17616f Compare August 11, 2026 07:06
@jhlegarreta

Copy link
Copy Markdown
Contributor Author

A few notes:

  • The failing tests had been skipped until now, and now that they are being run, it looks like the code needs to be revised.
  • Requiring FURY for the I/O is probably not the best approach. This is related to (i) the need to split the implementation from other accessory things here, and (ii) DIPY's reliance on FURY to read VTK tractograms. Due to version constraints, the FURY version being required here is already an unmaintained major series, with the risk of conflicting with Python versions, etc.

@skoudoro

Copy link
Copy Markdown
Collaborator

small note: FURY 2.0.0 has been released and do not depends on VTK anymore. it depends on https://github.com/fury-gl/polyxios.

DIPY will depend on Polyxios soon too

Comment thread pyproject.toml
@jhlegarreta

Copy link
Copy Markdown
Contributor Author

Re #125 (comment). That's great, Serge ! Thanks for that work.

@arokem

arokem commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

I am not Serge, but you're welcome 😄

@arokem

arokem commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Oh, you mean about polyoxios. Yes, excellent work there!

@jhlegarreta
jhlegarreta force-pushed the mnt/list-optional-deps branch from 0b9b059 to e17616f Compare August 11, 2026 17:14
@arokem
arokem merged commit 07ea4ef into tee-ar-ex:master Aug 11, 2026
26 of 28 checks passed
@jhlegarreta
jhlegarreta deleted the mnt/list-optional-deps branch August 12, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants