MNT: Fix OS matrix values in optional dependency job in CI workflow - #131
Merged
arokem merged 1 commit intoAug 21, 2026
Merged
Conversation
jhlegarreta
force-pushed
the
mnt/fix-os-matrix-optional-deps-job
branch
from
August 12, 2026 19:49
2d0db7e to
dcf6338
Compare
Contributor
Author
|
Failures are expected (x-ref #125 (comment)). Now the builds can be seen in the check matrix. |
jhlegarreta
force-pushed
the
mnt/fix-os-matrix-optional-deps-job
branch
from
August 13, 2026 06:37
dcf6338 to
b4c8ab7
Compare
Collaborator
|
Sorry, this was supplanted by my #135, but feel free to rebase and we can integrate this change instead, since it's probably a bit more concise. |
Fix OS matrix values in optional dependency job in CI workflow: use the appropriate syntax to store the values of the OS platforms in the `os.matrix` variable. In the current implementation, the variable is empty for the optional dependency job. Fixes: ``` Error when evaluating 'runs-on' for job 'test-optional-deps'. .github/workflows/test.yml (Line: 44, Col: 14): Unexpected value '' ``` visible for example in: https://github.com/tee-ar-ex/trx-python/actions/runs/31546085298 Take advantage of the commit to identify better the optional dependency job name by including the Python version and the OS.
jhlegarreta
force-pushed
the
mnt/fix-os-matrix-optional-deps-job
branch
from
August 21, 2026 11:38
b4c8ab7 to
389b701
Compare
Contributor
Author
|
@arokem Thanks for having a look at this. Rebased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 86.53% 86.53%
=======================================
Files 13 13
Lines 2896 2896
=======================================
Hits 2506 2506
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OS matrix values in optional dependency job in CI workflow: use the appropriate syntax to store the values of the OS platforms in the
os.matrixvariable. In the current implementation, the variable is empty for the optional dependency job.Fixes:
visible for example in:
https://github.com/tee-ar-ex/trx-python/actions/runs/31546085298