Skip to content

Update Windows Binary Install Instructions for Lyrical#6543

Merged
tfoote merged 6 commits into
ros2:rollingfrom
ppswaroopa:rolling
May 22, 2026
Merged

Update Windows Binary Install Instructions for Lyrical#6543
tfoote merged 6 commits into
ros2:rollingfrom
ppswaroopa:rolling

Conversation

@ppswaroopa
Copy link
Copy Markdown
Contributor

@ppswaroopa ppswaroopa commented May 4, 2026 •
edited
Loading

Description

Part of Lyrical Luth Testing Party Fixes

  • Clarify the requirement to use pixi shell when running ROS 2 commands
  • Add guidance for installing Visual Studio Build Tools for C++ builds

Fixes # (issue)

Did not find any matching existing issue. I enquired on Zulip chat and was suggested to bring in a PR.

Did you use Generative AI?

No

Additional Information

NA

@ppswaroopa
Copy link
Copy Markdown
Contributor Author

ppswaroopa commented May 4, 2026

Resolves issues I faced in ros2/lyrical_tutorial_party#2168 AND ros2/lyrical_tutorial_party#2618

@ppswaroopa ppswaroopa mentioned this pull request May 5, 2026
Open
@ppswaroopa ppswaroopa force-pushed the rolling branch 2 times, most recently from 533efa3 to b575237 Compare May 5, 2026 14:02
@ppswaroopa ppswaroopa mentioned this pull request May 5, 2026
Closed
fujitatomoya
fujitatomoya approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@ahcorde i would like to have an approval on this before merge.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented May 6, 2026

@ppswaroopa a couple of github workflows are failing, can you check them?

@ppswaroopa
Copy link
Copy Markdown
Contributor Author

ppswaroopa commented May 6, 2026 •
edited
Loading

@fujitatomoya it was a left over trailing white space. I have taken care of it now.

Is there a way I can run these tests locally? when I ran make test locally it reported many carriage return and validity errors, which is not consistent with the workflow output

Mat198
Mat198 suggested changes May 6, 2026
View reviewed changes
Comment thread source/How-To-Guides/Installation-Troubleshooting.rst Outdated
Comment thread source/Installation/Windows-Install-Binary.rst
@Aashishkumar-07
Copy link
Copy Markdown
Contributor

Aashishkumar-07 commented May 7, 2026

Have found another issue and have shared PR for the same @Mat198

@ppswaroopa
Copy link
Copy Markdown
Contributor Author

ppswaroopa commented May 10, 2026 •
edited
Loading

All comments have been resolved. Opened PR ros2/ros2#1840 to address the Qt path issue.

Please check and merge? @fujitatomoya @clalancette

Thanks

@ppswaroopa ppswaroopa requested a review from clalancette May 17, 2026 05:27
tfoote
tfoote approved these changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iterations and cleanup. This looks resolved now. Should this be backported beyond lyrical? If so haw far?

@ppswaroopa
Copy link
Copy Markdown
Contributor Author

ppswaroopa commented May 22, 2026

@tfoote , I opened this PR because the instructions were in some shape or way available for Jazzy and Humble but weren't for Lyrical.

However I do not know the validity of those instructions, nor about these updated instructions for lyrical working with older ones.

@tfoote tfoote merged commit fd2a9cb into ros2:rolling May 22, 2026
7 checks passed
@mergify mergify Bot mentioned this pull request May 22, 2026
Merged
tfoote added a commit that referenced this pull request May 22, 2026
@mergify @ppswaroopa @tfoote
Update Windows Binary Install Instructions for Lyrical (#6543) (#6851)
6b409b2 
* Update Windows Binary Install Instructions for Lyrical

* fix: trailing white space

* combined instructions on sourcing for windows binary install

* removed troubleshooting help for QT error

---------


(cherry picked from commit fd2a9cb)

Co-authored-by: Pranava Swaroopa <ppswaroopa@gmail.com>
Co-authored-by: Tully Foote <tullyfoote@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfoote tfoote tfoote approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette Awaiting requested review from clalancette

+1 more reviewer

@Mat198 Mat198 Mat198 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-lyrical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ppswaroopa @fujitatomoya @Aashishkumar-07 @clalancette @tfoote @Mat198