Skip to content

chore: remove replaces from ev-node#3158

Merged
julienrbrt merged 1 commit intomainfrom
julien/remove-replaces
Mar 12, 2026
Merged

chore: remove replaces from ev-node#3158
julienrbrt merged 1 commit intomainfrom
julien/remove-replaces

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 12, 2026

Overview

Summary by CodeRabbit

Chores

  • Updated dependency configuration to allow more flexible version resolution for Google API libraries instead of pinning to specific versions.

@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedMar 12, 2026, 4:19 PM

@claude
Copy link
Contributor

claude bot commented Mar 12, 2026

Claude finished @julienrbrt's task in 1m 1s —— View job


Code Review: chore: remove replaces from ev-node

  • Gather context and read changed files
  • Analyze go.mod changes
  • Provide review feedback

Summary

This PR removes three replace directives from go.mod that were pinning all google.golang.org/genproto variants to an older fixed version (v0.0.0-20240213162025-012b6fc9bca9), along with the direct dependency on the base google.golang.org/genproto package.


Changes

go.mod — Removes:

  1. The google.golang.org/genproto entry from require (the root package, not the sub-packages)
  2. The replace block that pinned all three genproto modules to a single older version

go.sum — The bulk of the diff (-977/+11): removing checksums for many transitive historical cloud.google.com/go .mod entries that were only pulled in by the old pinned genproto version.


Review

Correctness

The original replace block was a workaround for an old issue where different transitive dependencies pulled in incompatible genproto versions, causing ambiguous import errors. Removing these replaces means the Go module resolver will now pick the version determined by the dependency graph — in this case v0.0.0-20260209200024-4cfbd4190f57, which is significantly newer than the old pinned version (v0.0.0-20240213162025-012b6fc9bca9). This is the correct approach once the upstream ecosystem has settled on consistent versioning.

go.sum cleanup

The 977 deletions in go.sum are expected and clean — they represent checksum entries for old indirect cloud.google.com/go module versions that were only needed to satisfy the old pinned genproto. These are purely go.mod hash entries (not source code checksums), so their removal has no runtime impact.

Risk ✅ Low

  • The buf-check CI workflow has passed, confirming protobuf-related consistency
  • No application logic is changed; this is purely a dependency management cleanup
  • The sub-packages (googleapis/api, googleapis/rpc) that are actually used remain in require

Minor observation — worth confirming that the full test suite (just test / just test-integration) passes after this change, since removing replace directives can occasionally surface version skew issues at compile time. If CI is green across all jobs, this is ready to merge.


Overall: LGTM. Clean dependency hygiene — removing workaround replace pins in favor of proper module resolution is the right long-term approach.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 93af7627-6606-4163-89d9-6028b264fbf9

📥 Commits

Reviewing files that changed from the base of the PR and between abb6b71 and 323c300.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
💤 Files with no reviewable changes (1)
  • go.mod

📝 Walkthrough

Walkthrough

Removed explicit version pinning for google.golang.org/genproto dependency by deleting the indirect require directive and the associated replace block that pinned genproto along with its googleapis/api and googleapis/rpc counterparts to specific versions.

Changes

Cohort / File(s) Summary
Dependency Management
go.mod
Removed indirect version pin for google.golang.org/genproto from require block and deleted corresponding replace block directives for genproto, googleapis/api, and googleapis/rpc.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • tac0turtle

Poem

🐰 The genproto chains have been unbound,
No more pins keeping versions down,
Let the dependencies dance and be free,
In the go.mod module tree!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is completely empty, containing only the template comments with no actual content, context, background, or rationale provided. Fill in the Overview section with an explanation of why the replace directives are being removed and what impact this has on the project dependencies.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing replace directives from go.mod for the ev-node project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch julien/remove-replaces
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.20%. Comparing base (abb6b71) to head (323c300).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3158   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files         115      115           
  Lines       11896    11896           
=======================================
  Hits         7162     7162           
  Misses       3923     3923           
  Partials      811      811           
Flag Coverage Δ
combined 60.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt merged commit 2c9ca1b into main Mar 12, 2026
31 checks passed
@julienrbrt julienrbrt deleted the julien/remove-replaces branch March 12, 2026 16:25
alpe added a commit that referenced this pull request Mar 13, 2026
* main:
  build(deps): Bump quinn-proto from 0.11.13 to 0.11.14 in the cargo group across 1 directory (#3155)
  build(deps): bump execution/evm (#3160)
  build(deps): bump ev-node (#3159)
  chore: remove replaces from ev-node (#3158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants