Skip to content

build(deps): bump ev-node#3159

Merged
julienrbrt merged 1 commit intomainfrom
julien/bumps
Mar 12, 2026
Merged

build(deps): bump ev-node#3159
julienrbrt merged 1 commit intomainfrom
julien/bumps

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 12, 2026

Overview

Summary by CodeRabbit

  • Chores
    • Updated core dependency from release candidate to stable version across all modules, improving system stability and moving away from pre-release software.

@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedMar 12, 2026, 4:30 PM

@claude
Copy link
Contributor

claude bot commented Mar 12, 2026

Claude finished @julienrbrt's task in 1m 39s —— View job


Code Review

  • Gather context and analyze PR changes
  • Review dependency updates
  • Check for consistency across modules
  • Provide final review summary

Summary

This PR promotes github.com/evstack/ev-node from v1.0.0-rc.5 to the stable v1.0.0 release across all sub-modules in the monorepo, along with several transitive dependency bumps in tools/da-debug.

Observations

Positive:

  • The ev-node stable version bump is applied consistently across all 9 modules that reference it (apps/evm, apps/grpc, apps/testapp, execution/evm, execution/evm/test, execution/grpc, test/docker-e2e, test/e2e, tools/da-debug).
  • golang.org/x/crypto v0.48.0 update is a good security hygiene bump.
  • github.com/libp2p/go-libp2p v0.47.0 minor version bump is included transitively.

Notable — Commented-out replace directive (apps/testapp/go.mod:5):

//replace github.com/evstack/ev-node => ../../.

The replace directive was commented out rather than removed. While this was likely done in the previous PR (#3158 "remove replaces from ev-node"), it's worth confirming whether this is intentional for developer convenience (easy toggle for local dev) or should be cleaned up. A commented-out directive in a committed go.mod can cause confusion — contributors may not realize they need to uncomment it for local development, or may accidentally uncomment it and push.

RC versions still present in some modules:

  • apps/evm/go.mod: github.com/evstack/ev-node/execution/evm v1.0.0-rc.4
  • apps/grpc/go.mod: github.com/evstack/ev-node/execution/grpc v1.0.0-rc.1

These sub-modules (execution/evm and execution/grpc) are still on RC versions. This appears intentional since those modules haven't cut a stable release yet, but worth tracking.

go.sum completeness: The apps/testapp/go.sum has 2 new lines but no removals, while other modules properly show both additions and replacements. This looks correct as testapp is pulling in new hashes for the v1.0.0 release.

Verdict

This is a clean, mechanical dependency promotion PR. No functional code changes, and the version updates look correct. The commented replace directive is the only minor nit worth addressing if this is not an intentional convention.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e527be65-c7aa-491c-9fa9-e164f49a9205

📥 Commits

Reviewing files that changed from the base of the PR and between 2c9ca1b and 9d2f431.

⛔ Files ignored due to path filters (5)
  • apps/testapp/go.sum is excluded by !**/*.sum
  • execution/evm/go.sum is excluded by !**/*.sum
  • execution/grpc/go.sum is excluded by !**/*.sum
  • test/docker-e2e/go.sum is excluded by !**/*.sum
  • tools/da-debug/go.sum is excluded by !**/*.sum
📒 Files selected for processing (9)
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod
  • execution/evm/go.mod
  • execution/evm/test/go.mod
  • execution/grpc/go.mod
  • test/docker-e2e/go.mod
  • test/e2e/go.mod
  • tools/da-debug/go.mod

📝 Walkthrough

Walkthrough

This PR updates the github.com/evstack/ev-node dependency from release candidate versions (v1.0.0-rc.5 or v1.0.0-rc.1) to the stable v1.0.0 release across nine go.mod files. Additionally, a replace directive is commented out in apps/testapp/go.mod, and multiple indirect dependencies in tools/da-debug/go.mod are bumped to newer versions.

Changes

Cohort / File(s) Summary
EV-Node Stable Release
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod, execution/evm/go.mod, execution/evm/test/go.mod, execution/grpc/go.mod, test/docker-e2e/go.mod, test/e2e/go.mod
Updated github.com/evstack/ev-node from v1.0.0-rc.5 to v1.0.0 across all modules. In apps/testapp/go.mod, a replace directive was commented out during this update.
Indirect Dependency Updates
tools/da-debug/go.mod
Multiple indirect dependencies bumped: filecoin-project/go-jsonrpc (v0.10.0 → v0.10.1), ipfs/go-log/v2 (v2.9.0 → v2.9.1), libp2p/go-libp2p (v0.46.0 → v0.47.0), and several Go standard library packages (golang.org/x/crypto, golang.org/x/exp, golang.org/x/sync, golang.org/x/sys).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • tac0turtle
  • alpe

Poem

🐰 From release candidates we hop along,
To stable releases, so steady and strong!
Version bumps dance across go.mod files with glee,
Nine modules updated for all to see! 🎉
The EV-node stands tall, now v1.0.0 free!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch julien/bumps
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@julienrbrt julienrbrt merged commit 2ce328e into main Mar 12, 2026
24 of 25 checks passed
@julienrbrt julienrbrt deleted the julien/bumps branch March 12, 2026 16:31
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.22%. Comparing base (2c9ca1b) to head (9d2f431).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
+ Coverage   60.20%   60.22%   +0.01%     
==========================================
  Files         115      115              
  Lines       11896    11896              
==========================================
+ Hits         7162     7164       +2     
+ Misses       3923     3922       -1     
+ Partials      811      810       -1     
Flag Coverage Δ
combined 60.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alpe added a commit that referenced this pull request Mar 13, 2026
* main:
  build(deps): Bump quinn-proto from 0.11.13 to 0.11.14 in the cargo group across 1 directory (#3155)
  build(deps): bump execution/evm (#3160)
  build(deps): bump ev-node (#3159)
  chore: remove replaces from ev-node (#3158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants