Skip to content

feat(cryptoki): migrate dependencies to score_crates and remove crate_universe - #436

Open
ShoroukRamzy wants to merge 3 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:cryptoki-score-crates-migration
Open

ShoroukRamzy wants to merge 3 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:cryptoki-score-crates-migration

Conversation

@ShoroukRamzy

@ShoroukRamzy ShoroukRamzy commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Note
This pr is stacked on #317 and should be merged after it.

changes
migrate all cryptoki dependencies on universe crates to score crates

unblocks #173

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

@sunildevda, @OliverHeilwagen, please check after #317 . Thanks!

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.8.2) and connecting to it...
INFO: Invocation ID: 377f14c2-0745-44e6-b108-735f8f41de2f
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.8.5, but got rules_python@1.9.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_bazel_platforms', the root module requires module version score_bazel_platforms@0.1.2, but got score_bazel_platforms@1.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.2.22, but got rules_cc@0.2.26 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/crypto/crypto/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/crypto/crypto/BUILD
INFO: Elapsed time: 14.307s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-436: https://eclipse-score.github.io/inc_security_crypto/pr-436/

],
] + select({
"@score_openssl//:dynamic_openssl_enabled": [
"@score_openssl//:openssl_shared",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a combinaton of select switches?

  • Dynamic openssl enabled
    • openssl backend enabled -> add openssl_shared
    • pkcs11 enabled -> add pkcs11_shared_backend

@ShoroukRamzy ShoroukRamzy Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OliverHeilwagen, please note this PR is stacked on top of this PR #317 and previously we planned to open dedicated PR for this issue #317 (comment). and #348

The actual scope of this PR is only this commit 2c63e01.

So to keep PR scopes clean and maintain the release timeline I propose the following plan:
1-first PR to merge #317
2.second PR, this one.
3. I will create another PR (stacked on the first PR) to fix the current coupling issue between openssl and pkcs11
Both PR 2,3 depend on PR1 and I suggest to merge PR2 first to unblock the first release. What do you think?

srcs = ["init_pkcs11_token.cpp"],
dynamic_deps = select({
"@score_openssl//:dynamic_openssl_enabled": [
"@score_openssl//:openssl_shared",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same topic as for daemon we should have a coupling of shared library enabled + dedicated backend enabled.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once fixed we should do local trials for the combinations which are not executed in the CI.

Comment thread MODULE.bazel
Comment on lines +165 to +169
bazel_dep(name = "score_crates", version = "0.0.7")
git_override(
module_name = "score_crates",
commit = "871234431b05bc99b249fb5db775bbe850ed7f0d",
remote = "https://github.com/eclipse-score/score-crates.git",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git_override only applies when this repository is the root module; it is ignored when score_crypto is consumed as a dependency. The published score_crates v0.0.7 does not expose most of the labels used by this PR, such as argon2, dirs, once_cell, parking_lot, parsec_client, serial_test, toml, zeroize, and openssl. The latest v0.0.15 also predates score-crates PR #79. As a result, this repository’s CI passes with the override, but a downstream consumer can fail during Bazel analysis. Could we publish a new score_crates version containing #79, depend on that version, and remove the temporary override?

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — 7f6cb76d Waiting Nov 19, 2026 by ShoroukRamzy via Build and Test aarch64-qnx / approval #1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants