Repository navigation
feat(cryptoki): migrate dependencies to score_crates and remove crate_universe - #436
ShoroukRamzy wants to merge 3 commits into
Conversation
|
@sunildevda, @OliverHeilwagen, please check after #317 . Thanks! |
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
Documentation preview for this pull request is available at: |
| ], | ||
| ] + select({ | ||
| "@score_openssl//:dynamic_openssl_enabled": [ | ||
| "@score_openssl//:openssl_shared", |
There was a problem hiding this comment.
Don't we need a combinaton of select switches?
- Dynamic openssl enabled
- openssl backend enabled -> add openssl_shared
- pkcs11 enabled -> add pkcs11_shared_backend
There was a problem hiding this comment.
@OliverHeilwagen, please note this PR is stacked on top of this PR #317 and previously we planned to open dedicated PR for this issue #317 (comment). and #348
The actual scope of this PR is only this commit 2c63e01.
So to keep PR scopes clean and maintain the release timeline I propose the following plan:
1-first PR to merge #317
2.second PR, this one.
3. I will create another PR (stacked on the first PR) to fix the current coupling issue between openssl and pkcs11
Both PR 2,3 depend on PR1 and I suggest to merge PR2 first to unblock the first release. What do you think?
| srcs = ["init_pkcs11_token.cpp"], | ||
| dynamic_deps = select({ | ||
| "@score_openssl//:dynamic_openssl_enabled": [ | ||
| "@score_openssl//:openssl_shared", |
There was a problem hiding this comment.
Same topic as for daemon we should have a coupling of shared library enabled + dedicated backend enabled.
There was a problem hiding this comment.
Once fixed we should do local trials for the combinations which are not executed in the CI.
2c63e01 to
5de37e7
Compare
5de37e7 to
9dea9c7
Compare
9dea9c7 to
7f6cb76
Compare
| bazel_dep(name = "score_crates", version = "0.0.7") | ||
| git_override( | ||
| module_name = "score_crates", | ||
| commit = "871234431b05bc99b249fb5db775bbe850ed7f0d", | ||
| remote = "https://github.com/eclipse-score/score-crates.git", |
There was a problem hiding this comment.
git_override only applies when this repository is the root module; it is ignored when score_crypto is consumed as a dependency. The published score_crates v0.0.7 does not expose most of the labels used by this PR, such as argon2, dirs, once_cell, parking_lot, parsec_client, serial_test, toml, zeroize, and openssl. The latest v0.0.15 also predates score-crates PR #79. As a result, this repository’s CI passes with the override, but a downstream consumer can fail during Bazel analysis. Could we publish a new score_crates version containing #79, depend on that version, and remove the temporary override?
Note
This pr is stacked on #317 and should be merged after it.
changes
migrate all cryptoki dependencies on universe crates to score crates
unblocks #173