Repository navigation
feat(cryptoki): migrate dependencies to score_crates and remove crate_universe #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,13 @@ cc_binary( | |
| "-O1", | ||
| ], | ||
| }), | ||
| dynamic_deps = select({ | ||
| "@score_openssl//:dynamic_openssl_enabled": [ | ||
| "@score_openssl//:openssl_shared", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't we need a combinaton of select switches?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @OliverHeilwagen, please note this PR is stacked on top of this PR #317 and previously we planned to open dedicated PR for this issue #317 (comment). and #348 The actual scope of this PR is only this commit 2c63e01. So to keep PR scopes clean and maintain the release timeline I propose the following plan: |
||
| "//score/crypto/src/backend:pkcs11_shared_backend", | ||
| ], | ||
| "//conditions:default": [], | ||
| }), | ||
| includes = ["IPC"], | ||
| linkopts = select({ | ||
| "//conditions:default": [], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git_overrideonly applies when this repository is the root module; it is ignored whenscore_cryptois consumed as a dependency. The publishedscore_cratesv0.0.7 does not expose most of the labels used by this PR, such as argon2, dirs, once_cell, parking_lot, parsec_client, serial_test, toml, zeroize, and openssl. The latest v0.0.15 also predates score-crates PR #79. As a result, this repository’s CI passes with the override, but a downstream consumer can fail during Bazel analysis. Could we publish a new score_crates version containing #79, depend on that version, and remove the temporary override?