Skip to content

Add score_crypto to known_good. - #490

Draft
OliverHeilwagen wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:add_score_crypto
Draft

OliverHeilwagen wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:add_score_crypto

Conversation

@OliverHeilwagen

@OliverHeilwagen OliverHeilwagen commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Trial integration of inc_security_crypto.
Current status integration steps:

  • step 1 add module: done
  • step 2 documentation: done
  • step 3 unit test: done via test_and_docs (module_tests.py)
  • step 4 platforms: added //showcases/standalone:crypto as build check
  • step 5 component integration tests: done via test_and_docs (module_tests.py)
  • step 6 feature integration tests: done via test_and_docs (module_tests.py)
  • step 7 reporting: done via test_and_docs (module_tests.py)
  • step 8 pending

Demanded changes on main eclipse-score/inc_security_crypto:

Rename repository:

Additional included changes:

Comment thread known_good.json Outdated
},
"score_security_crypto": {
"repo": "https://github.com/etas-contrib/score_inc_security_crypto.git",
"hash": "c06c3171d620707ac4756a8d085722eaca66a7e3",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch to release version once available

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main shall use hashes

Comment thread known_good.json Resolved
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************
bazel_dep(name = "rules_python", version = "1.8.3")
bazel_dep(name = "rules_python", version = "1.9.0")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trial update to 1.9.0 will come with score-crates update.

@OliverHeilwagen
OliverHeilwagen force-pushed the add_score_crypto branch 2 times, most recently from 9cdaed0 to 1d1171b Compare November 18, 2026 10:01
@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html


+# score_tooling's flatbuffers 25.9.23 reaches rules_foreign_cc via grpc 1.70.1, opencensus-cpp and
+# google_benchmark 1.8.4. reference_integration resolves flatbuffers 25.12.19.bcr.1 (grpc 1.76.0), which does not.
+# module_tests.py only reads the module's original mod graph and does not yet iterate to apply the

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PiotrKorkus not sure if this is the first occurrence, but here we have a case where the final module mod graph is differing from the initial.

Such a disappearing dependency is probably the case which will lead to a failure a missing override via module_test.py stays most likely silent. Do we have a follow up issue to introduce this recursive check?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants