Repository navigation
Add score_crypto to known_good. #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6971c96
70bb13d
e1411a7
29baf6e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| diff --git a/MODULE.bazel b/MODULE.bazel | ||
| index 180bbe8..7c8c94a 100644 | ||
| --- a/MODULE.bazel | ||
| +++ b/MODULE.bazel | ||
| @@ -63,7 +63,7 @@ bazel_dep(name = "rules_cc", version = "0.2.22") | ||
| # ******************************************************************************* | ||
| bazel_dep( | ||
| name = "score_bazel_cpp_toolchains", | ||
| - version = "1.0.5", | ||
| + version = "1.1.0-rc2", | ||
| dev_dependency = True, | ||
| ) | ||
|
|
||
| @@ -105,7 +105,7 @@ gcc.toolchain( | ||
| # ******************************************************************************* | ||
| gcc.toolchain( | ||
| name = "score_qcc_x86_64_toolchain", | ||
| - sdp_version = "8.0.4", | ||
| + sdp_version = "8.0.5", | ||
| target_cpu = "x86_64", | ||
| target_os = "qnx", | ||
| use_default_package = True, | ||
| @@ -117,7 +117,7 @@ gcc.toolchain( | ||
| # ******************************************************************************* | ||
| gcc.toolchain( | ||
| name = "score_qcc_aarch64_toolchain", | ||
| - sdp_version = "8.0.4", | ||
| + sdp_version = "8.0.5", | ||
| target_cpu = "aarch64", | ||
| target_os = "qnx", | ||
| use_default_package = True, | ||
| @@ -125,12 +125,11 @@ gcc.toolchain( | ||
| ) | ||
| use_repo( | ||
| gcc, | ||
| + "qnx_sdp_8_0_5_pkg", | ||
| "score_gcc_aarch64_toolchain", | ||
| "score_gcc_x86_64_toolchain", | ||
| "score_qcc_aarch64_toolchain", | ||
| - "score_qcc_aarch64_toolchain_pkg", | ||
| "score_qcc_x86_64_toolchain", | ||
| - "score_qcc_x86_64_toolchain_pkg", | ||
| ) | ||
|
|
||
| # ******************************************************************************* | ||
| @@ -177,7 +176,7 @@ bazel_dep(name = "score_rules_imagefs", version = "0.0.3", dev_dependency = True | ||
| imagefs = use_extension("@score_rules_imagefs//extensions:imagefs.bzl", "imagefs", dev_dependency = True) | ||
| imagefs.toolchain( | ||
| name = "score_qnx_x86_64_ifs_toolchain", | ||
| - sdp_to_import = "@score_qcc_x86_64_toolchain_pkg", | ||
| + sdp_to_import = "@qnx_sdp_8_0_5_pkg", | ||
| sdp_version = "8.0.0", | ||
| target_cpu = "x86_64", | ||
| target_os = "qnx", | ||
| @@ -185,7 +184,7 @@ imagefs.toolchain( | ||
| ) | ||
| imagefs.toolchain( | ||
| name = "score_qnx_aarch64_ifs_toolchain", | ||
| - sdp_to_import = "@score_qcc_aarch64_toolchain_pkg", | ||
| + sdp_to_import = "@qnx_sdp_8_0_5_pkg", | ||
| sdp_version = "8.0.0", | ||
| target_cpu = "aarch64", | ||
| target_os = "qnx", |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| exports_files( | ||
| [ | ||
| "001-bazel-cpp-toolchains-1.1-qnx-sdp-pkg.patch", | ||
| ], | ||
| visibility = ["//visibility:public"], | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| diff --git a/MODULE.bazel b/MODULE.bazel | ||
| --- a/MODULE.bazel | ||
| +++ b/MODULE.bazel | ||
| @@ -28,6 +28,13 @@ | ||
| bazel_dep(name = "score_docs_as_code", version = "8.0.1") | ||
| bazel_dep(name = "score_tooling", version = "2.2.1") | ||
|
|
||
| +# score_tooling's flatbuffers 25.9.23 reaches rules_foreign_cc via grpc 1.70.1, opencensus-cpp and | ||
| +# google_benchmark 1.8.4. reference_integration resolves flatbuffers 25.12.19.bcr.1 (grpc 1.76.0), which does not. | ||
| +# module_tests.py only reads the module's original mod graph and does not yet iterate to apply the | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @PiotrKorkus not sure if this is the first occurrence, but here we have a case where the final module mod graph is differing from the initial. Such a disappearing dependency is probably the case which will lead to a failure a missing override via module_test.py stays most likely silent. Do we have a follow up issue to introduce this recursive check?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here the former build issue: |
||
| +# --override_module pins according to the final graph, so it would pin rules_foreign_cc, which | ||
| +# Bazel then rejects as an override on a nonexistent module. Raising flatbuffers here removes that edge. | ||
| +bazel_dep(name = "flatbuffers", version = "25.12.19.bcr.1", dev_dependency = True) | ||
| + | ||
| # LLVM source-based coverage pipeline: the qualified S-CORE coverage tool, | ||
| # successor of @score_tooling//coverage. See tools/coverage/. | ||
| bazel_dep(name = "score_coverage", version = "0.3.1", dev_dependency = True) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- a/foreign_cc/private/cmake_script.bzl | ||
| +++ b/foreign_cc/private/cmake_script.bzl | ||
| @@ -20,6 +20,7 @@ | ||
| "ios": "iOS", | ||
| "linux": "Linux", | ||
| "macos": "Darwin", | ||
| + "qnx": "QNX", | ||
| "tvos": "tvOS", | ||
| "watchos": "watchOS", | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| exports_files( | ||
| [ | ||
| "001-qnx-cmake-system-name.patch", | ||
| ], | ||
| visibility = ["//visibility:public"], | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trial update to 1.9.0 will come with score-crates update.