feat(weave): scorer_* typed columns on feedback#6908
Open
nikumar1206 wants to merge 5 commits into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a5abc6098f8600bfba0ed1f2ad9a2248ddbd673b |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
3165f98 to
7d85f02
Compare
bb33ae8 to
33c36ec
Compare
7d85f02 to
cf341ff
Compare
d80d70b to
39e2cad
Compare
1cb0e5e to
63cb0b4
Compare
cf341ff to
34b26b1
Compare
jtschoonhoven
approved these changes
May 21, 2026
Contributor
jtschoonhoven
left a comment
There was a problem hiding this comment.
Approving to unblock, but see comments. Lmk if you want to discuss more.
1a7832a to
94d6f83
Compare
63cb0b4 to
dab1855
Compare
94d6f83 to
74e66c5
Compare
dab1855 to
55dd6ab
Compare
74e66c5 to
fa18f44
Compare
55dd6ab to
7d46052
Compare
7d46052 to
200a56f
Compare
b3d41e6 to
b48e754
Compare
b48e754 to
39a1b35
Compare
jtschoonhoven
approved these changes
May 22, 2026
Contributor
jtschoonhoven
left a comment
There was a problem hiding this comment.
One comment to address, otherwise LGMT.
Let's not merge this until after the migration has been deployed just in case.
Co-authored-by: Jonathan Schoonhoven <jschoonhoven@wandb.com>
39a1b35 to
dd558dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Wires the four `scorer_*` columns from #6906 through the trace-server so they round-trip via the existing feedback endpoints.
Testing
Unit tests.