feat(weave): add wandb.agent_monitor feedback type#6909
Open
nikumar1206 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=ec7b0fff866030c94db7fd8804d2e50f090298e6 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
2 times, most recently
from
b9838f8 to
62f4c20
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
bb33ae8 to
33c36ec
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
from
62f4c20 to
8ec7e74
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
d80d70b to
39e2cad
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
2 times, most recently
from
76c285f to
b002e37
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
2ed81a6 to
1cb0e5e
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
from
b002e37 to
042a0c0
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
1cb0e5e to
63cb0b4
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
2 times, most recently
from
1a857fa to
77c114c
Compare
Contributor
jtschoonhoven
left a comment
jtschoonhoven
left a comment
There was a problem hiding this comment.
Requesting a few small changes before we merge
| f"Invalid payload for feedback_type {req.feedback_type}: {e}" | ||
| ) from e | ||
| elif feedback_type_is_agent_monitor(req.feedback_type): | ||
| if not req.runnable_ref: |
Contributor
There was a problem hiding this comment.
We should also require trigger_ref here
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
63cb0b4 to
dab1855
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
2 times, most recently
from
893c8f7 to
577fcab
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
dab1855 to
55dd6ab
Compare
jtschoonhoven
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
55dd6ab to
7d46052
Compare
jtschoonhoven
requested review from
gtarpenning,
neutralino1 and
tssweeney
as code owners
jtschoonhoven
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
7d46052 to
200a56f
Compare
jtschoonhoven
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
from
577fcab to
a4d6155
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
from
a4d6155 to
6f6503e
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
2 times, most recently
from
b48e754 to
39a1b35
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
2 times, most recently
from
9a478a2 to
35db1c8
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-agent-monitor-type
branch
from
35db1c8 to
4b8dbc0
Compare
nikumar1206
force-pushed
the
nikhil/scorer-feedback-columns-wiring
branch
from
39a1b35 to
dd558dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the `wandb.agent_monitor` feedback_type. Scorer identity comes from `runnable_ref` (no `.` suffix like `wandb.runnable.*`).
Validation:
Testing
Unit tests.