fix: crash when saving a row with all empty values#751
Merged
theoephraim merged 3 commits intomainfrom Feb 14, 2026
Merged
Conversation
The Google Sheets API omits `values` from the response when all cells are empty, and truncates trailing empty cells. This caused a crash on `row.save()` and inconsistent `undefined` vs `''` for empty cells. Fix by padding `_rawData` to match header length with empty strings, both in the constructor (covers getRows/addRows) and after save(). Fixes #558, closes #644 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5262e8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Ensure empty cells in rows always return '' instead of undefined - Move merge/unmerge tests from rows.test.ts to cells.test.ts where they belong, rewritten to use cell-based assertions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…r empty cells Empty cells now consistently return '' after rawData padding normalization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
row.save()after clearing all values in a row — the Google Sheets API omitsvaluesfrom the response when all cells are empty, causingCannot read properties of undefined (reading '0')undefinedinstead of''— the API truncates trailing empty values from arrays, sorow.get('trailingColumn')would returnundefinedinstead of''_rawDatato always match header length with empty strings, both in theGoogleSpreadsheetRowconstructor (coversgetRows/addRows) and aftersave()Incorporates #558, fixes #644
Test plan
''(notundefined)save()works without crashingtoObject()returns''for cleared values (notundefined)🤖 Generated with Claude Code