Error when trying to save an empty row.#558
Closed
GabbyPly wants to merge 1 commit intotheoephraim:mainfrom
Closed
Error when trying to save an empty row.#558GabbyPly wants to merge 1 commit intotheoephraim:mainfrom
GabbyPly wants to merge 1 commit intotheoephraim:mainfrom
Conversation
…not the same as deleting one. sending an array of empty strings such as ["", ""] (Clearing the row) will result in a response with no `.value` in it, thus causing an error `cannot read property '0' of undefined. This fix will return an array of empty strings, the array of the length is the array of the original request's rawData
theoephraim
force-pushed
the
main
branch
5 times, most recently
from
cf803e0 to
53fe384
Compare
theoephraim
force-pushed
the
main
branch
3 times, most recently
from
2fd9b63 to
c1e0285
Compare
theoephraim
force-pushed
the
main
branch
3 times, most recently
from
0b28021 to
ea334d8
Compare
theoephraim
added a commit
that referenced
this pull request
Feb 14, 2026
The Google Sheets API omits `values` from the response when all cells are empty, and truncates trailing empty cells. This caused a crash on `row.save()` and inconsistent `undefined` vs `''` for empty cells. Fix by padding `_rawData` to match header length with empty strings, both in the constructor (covers getRows/addRows) and after save(). Fixes #558, closes #644 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
Owner
|
fixed in #751 - thanks and sorry for the extreme delay :) |
theoephraim
added a commit
that referenced
this pull request
Feb 14, 2026
* fix: crash when saving a row with all empty values The Google Sheets API omits `values` from the response when all cells are empty, and truncates trailing empty cells. This caused a crash on `row.save()` and inconsistent `undefined` vs `''` for empty cells. Fix by padding `_rawData` to match header length with empty strings, both in the constructor (covers getRows/addRows) and after save(). Fixes #558, closes #644 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: normalize empty row cells to '' and move merge tests to cells - Ensure empty cells in rows always return '' instead of undefined - Move merge/unmerge tests from rows.test.ts to cells.test.ts where they belong, rewritten to use cell-based assertions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: update insertDimension test to expect '' instead of undefined for empty cells Empty cells now consistently return '' after rawData padding normalization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error when trying to save an empty row. Note, saving an empty row is not the same as deleting one.
sending an array of empty strings such as ["", ""] (Clearing the row)
will result in a response with no
.valuein it, thus causing an errorcannot read property '0' of undefined.This fix will return an array of empty strings, the array of the length is the array of the original request's rawData