Skip to content

fix: update default tracing endpoint to http protobuf endpoint #9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
waveywaves wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update default tracing endpoint to http protobuf endpoint #9141

waveywaves wants to merge 1 commit into from

Conversation

@waveywaves
Copy link
Member

@waveywaves waveywaves commented Nov 13, 2025

Changes

currently the otel sdk is used to export metrics in the protobuf format, for the sake of consistency this commit makes sure that we use 4318 with /v1/traces as the default jaegar tracing endpoint use port 4318 with /v1/traces for the default jaegar tracing endpoint instead of port 14268 with /api/traces endpoint.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 13, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2025
@waveywaves waveywaves added the kind/bug Categorizes issue or PR as related to a bug. label Nov 13, 2025
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
twoGiants
twoGiants approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/meow

@tekton-robot
Copy link
Collaborator

tekton-robot commented Nov 13, 2025

@twoGiants: cat image

In response to this:

/approve
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: twoGiants, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@waveywaves waveywaves mentioned this pull request Nov 13, 2025
Merged
4 tasks
@waveywaves waveywaves force-pushed the tracing/default-endpoint-fix branch from 21c9a60 to d7e5891 Compare November 13, 2025 11:27
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@waveywaves waveywaves added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@waveywaves waveywaves force-pushed the tracing/default-endpoint-fix branch from d7e5891 to 26bb1a3 Compare November 13, 2025 12:30
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@waveywaves waveywaves changed the title fix: update default tracing endpoint to protobuf endpoint fix: update default tracing endpoint to http protobuf endpoint Nov 13, 2025
@vdemeester
Copy link
Member

vdemeester commented Nov 13, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@waveywaves
Copy link
Member Author

waveywaves commented Nov 13, 2025

/retest

@waveywaves
Copy link
Member Author

waveywaves commented Nov 13, 2025

/meow

@tekton-robot
Copy link
Collaborator

tekton-robot commented Nov 13, 2025

@waveywaves: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves
Copy link
Member Author

waveywaves commented Nov 14, 2025

/retest

1 similar comment
@waveywaves
Copy link
Member Author

waveywaves commented Nov 16, 2025

/retest

@waveywaves
fix: update default tracing endpoint to oltp protobuf endpoint
cd55e73 
currently the otel sdk is used to export metrics in the protobuf
format, for the sake of consistency this commit makes sure that we
use 4318 with /v1/traces as the default jaegar tracing endpoint
use port 4318 with /v1/traces for the default jaegar tracing endpoint
instead of port 14268 with /api/traces endpoint.
@waveywaves waveywaves force-pushed the tracing/default-endpoint-fix branch from 26bb1a3 to cd55e73 Compare November 16, 2025 09:07
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Nov 16, 2025

New changes are detected. LGTM label has been removed.

@waveywaves
Copy link
Member Author

waveywaves commented Nov 16, 2025

/meow

@tekton-robot
Copy link
Collaborator

tekton-robot commented Nov 16, 2025

@waveywaves: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves
Copy link
Member Author

waveywaves commented Nov 16, 2025

/retest

2 similar comments
@waveywaves
Copy link
Member Author

waveywaves commented Nov 17, 2025

/retest

@waveywaves
Copy link
Member Author

waveywaves commented Nov 17, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

+1 more reviewer

@twoGiants twoGiants twoGiants approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vdemeester vdemeester

@twoGiants twoGiants

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@waveywaves @tekton-robot @vdemeester @twoGiants