Skip to content

Commit 26bb1a3

Browse files
committed
fix: update default tracing endpoint to oltp protobuf endpoint
currently the otel sdk is used to export metrics in the protobuf format, for the sake of consistency this commit makes sure that we use 4318 with /v1/traces as the default jaegar tracing endpoint use port 4318 with /v1/traces for the default jaegar tracing endpoint instead of port 14268 with /api/traces endpoint.
1 parent 349c0ea commit 26bb1a3

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

config/config-tracing.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ data:
4141
#
4242
# API endpoint to send the traces to
4343
# (optional): The default value is given below
44-
endpoint: "http://jaeger-collector.jaeger.svc.cluster.local:14268/api/traces"
44+
endpoint: "http://jaeger-collector.jaeger.svc.cluster.local:4318/v1/traces"
4545
# (optional) Name of the k8s secret which contains basic auth credentials
4646
credentialsSecret: "jaeger-creds"

pkg/apis/config/tracing.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const (
3434
tracingCredentialsSecretKey = "credentialsSecret"
3535

3636
// DefaultEndpoint is the default destination for sending traces
37-
DefaultEndpoint = "http://jaeger-collector.jaeger.svc.cluster.local:14268/api/traces"
37+
DefaultEndpoint = "http://jaeger-collector.jaeger.svc.cluster.local:4318/v1/traces"
3838
)
3939

4040
// DefaultTracing holds all the default configurations for tracing

pkg/apis/config/tracing_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func TestNewTracingFromConfigMap(t *testing.T) {
3535
name: "empty",
3636
want: &config.Tracing{
3737
Enabled: false,
38-
Endpoint: "http://jaeger-collector.jaeger.svc.cluster.local:14268/api/traces",
38+
Endpoint: "http://jaeger-collector.jaeger.svc.cluster.local:4318/v1/traces",
3939
},
4040
fileName: "config-tracing-empty",
4141
},

0 commit comments

Comments
 (0)