apollo_network: migrate BootstrappingBehaviour to delegate dialling to DiallingBehaviour

[sirandreww-starkware]

Note

Medium Risk
Changes bootstrapping connection lifecycle and shifts dial/retry responsibility to the shared DialingBehaviour, which could affect reconnect behavior and event ordering if routing is incorrect.

Overview
Bootstrapping no longer performs libp2p dials directly. BootstrappingBehaviour is rewritten to maintain a HashMap of bootstrap peers and emit queued ToOtherBehaviourEvent::RequestDial events (initially and on full disconnect), relying on the existing DialingBehaviour to execute dials and handle retry/backoff.

On successful outbound connection to a bootstrap peer, it now emits FoundListenAddresses and explicitly drops any queued stale RequestDial for that peer to handle rapid disconnect/reconnect ordering.

Tests are updated to assert RequestDial/routing behavior (including a new rapid reconnect case), Discovery test wiring simulates network-manager routing by forwarding RequestDial to DialingBehaviour, and the e2e broadcast test avoids early swarm polling that would otherwise drop initial RequestDial events.

^{Written by Cursor Bugbot for commit b9f5e9d. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

• apollo_network: expose add_epoch as a channel-based API on network manager #13389
• apollo_network: add peer access control behaviour to deny unauthorized inbound connections #13285
• apollo_network: cancel stale DialPeerStreams when target peers are removed #13282
• apollo_network: added end to end discovery test #13097
• apollo_network: added testing event exporter to network manager #13242
• apollo_network: moved route_to_other_behaviour_event to mixed behaviour #13096
• apollo_network: migrate BootstrappingBehaviour to delegate dialling to DiallingBehaviour #13219 👈 (View in Graphite)
• apollo_network: KadRequesting emits RequestDial events via DiallingBehaviour #13218
• apollo_network: wire DiallingBehaviour into Discovery with RequestDial event #13217
• apollo_network: propagate multiaddresses from Kad query results #13216
• apollo_network: implement DiallingBehaviour using DialPeerStream via SelectAll #13215
• apollo_network: add DialPeerStream for dialling behaviour #13214
• apollo_network: add DiallingBehaviour skeleton #13213
• apollo_network: changed KadRequesting to dial the peers returned from Kad query #13116
• apollo_network: removed random KadRequests #13095
• apollo_network: pass allowed peers to KadRequestingBehaviour on epoch registration #13094
• apollo_network: using ActiveCommittees in NetworkManager #13075
• apollo_network: add CommitteeStore with read/write API #12382 : 1 other dependent PR (#12583 )
• apollo_network: add committee_manager module with core types #12381
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ShahakShama and sirandreww-starkware).

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 47 at r1 (raw file):

        for (peer_id, address) in bootstrap_peers {
            if peer_id == local_peer_id {
                info!("Skipping bootstrap peer with same ID as local peer: {address}");

Is this going to trigger every time the node comes up? Or only for some of the nodes that happen to be on the list of bootstraps? If every time, I'm not sure it deserves a log.

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 58 at r1 (raw file):

        if peers_map.is_empty() {
            warn!("No bootstrap peers provided, bootstrapping will not be possible");

Not sure if we want a panic here or not. How bad is it to come up without bootstrap peers?

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on guy-starkware and ShahakShama).

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 47 at r1 (raw file):

Previously, guy-starkware wrote…

Is this going to trigger every time the node comes up? Or only for some of the nodes that happen to be on the list of bootstraps? If every time, I'm not sure it deserves a log.

This code has been moved but not changed. If you'd like I can move it back to where it was?

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 58 at r1 (raw file):

Previously, guy-starkware wrote…

Not sure if we want a panic here or not. How bad is it to come up without bootstrap peers?

This code has been moved but not changed. If you'd like I can move it back to where it was?

[guy-starkware]

@guy-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ShahakShama and sirandreww-starkware).

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 47 at r1 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

This code has been moved but not changed. If you'd like I can move it back to where it was?

No, I was just thinking about this info! log. You don't have to change it at this point but consider if this log gives me any additional information.

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 58 at r1 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

This code has been moved but not changed. If you'd like I can move it back to where it was?

I don't mind where the code is. Just reading through it and suggesting what ever I see. If you don't want to make changes to the moved code just now at least think about modifying it later.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[ShahakShama]

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 106 at r2 (raw file):

            }) => {
                if let Some(address) = self.bootstrap_peers.get(&peer_id) {
                    self.pending_events.push_back(ToOtherBehaviourEvent::FoundListenAddresses {

Was this here in the previous discovery? I think no. I think it only appears in identify

[sirandreww-starkware]

@sirandreww-starkware made 2 comments and resolved 2 discussions.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on guy-starkware and ShahakShama).

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 106 at r2 (raw file):

Previously, ShahakShama wrote…

Was this here in the previous discovery? I think no. I think it only appears in identify

It was, I tagged you in that location

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/bootstrap_peer.rs line 146 at r3 (raw file):

                    self.should_add_peer_to_kad_routing_table = false;
                    Poll::Ready(Some(ToSwarm::GenerateEvent(
                        ToOtherBehaviourEvent::FoundListenAddresses {

@ShahakShama this shows what you asked about

[ShahakShama]

@ShahakShama reviewed 3 files and all commit messages, made 2 comments, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

---

crates/apollo_network/src/discovery/behaviours/bootstrapping/mod.rs line 106 at r2 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

It was, I tagged you in that location

Ah ok, this is for peer manager