apollo_network: wire DiallingBehaviour into Discovery with RequestDial event

[sirandreww-starkware]

Note

Medium Risk
Adds a new dialing sub-behaviour to discovery and introduces a new cross-behaviour RequestDial event, which can affect peer connection flow and retry behaviour. Risk is moderate because it changes swarm behaviour composition and event routing but is scoped to discovery/dial logic.

Overview
Discovery now includes an explicit peer-dialing behaviour with retry support, and routes dial requests through the discovery event bridge.

This renames the dialling behaviour/module to dialing, exports DialingBehaviour, adds ToOtherBehaviourEvent::RequestDial, and updates Behaviour::new and on_other_behaviour_event to instantiate the dialer and invoke dialing.request_dial when the new event is received.

^{Written by Cursor Bugbot for commit 8120ff7. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

• apollo_network: expose add_epoch as a channel-based API on network manager #13389
• apollo_network: add peer access control behaviour to deny unauthorized inbound connections #13285
• apollo_network: cancel stale DialPeerStreams when target peers are removed #13282
• apollo_network: added end to end discovery test #13097
• apollo_network: added testing event exporter to network manager #13242
• apollo_network: moved route_to_other_behaviour_event to mixed behaviour #13096
• apollo_network: migrate BootstrappingBehaviour to delegate dialling to DiallingBehaviour #13219
• apollo_network: KadRequesting emits RequestDial events via DiallingBehaviour #13218
• apollo_network: wire DiallingBehaviour into Discovery with RequestDial event #13217 👈 (View in Graphite)
• apollo_network: propagate multiaddresses from Kad query results #13216
• apollo_network: implement DiallingBehaviour using DialPeerStream via SelectAll #13215
• apollo_network: add DialPeerStream for dialling behaviour #13214
• apollo_network: add DiallingBehaviour skeleton #13213
• apollo_network: changed KadRequesting to dial the peers returned from Kad query #13116
• apollo_network: removed random KadRequests #13095
• apollo_network: pass allowed peers to KadRequestingBehaviour on epoch registration #13094
• apollo_network: using ActiveCommittees in NetworkManager #13075
• apollo_network: add CommitteeStore with read/write API #12382 : 1 other dependent PR (#12583 )
• apollo_network: add committee_manager module with core types #12381
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[guy-starkware]

@guy-starkware reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama and sirandreww-starkware).

[sirandreww-starkware]

@sirandreww-starkware made 1 comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on guy-starkware and ShahakShama).

[ShahakShama]

@ShahakShama reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on guy-starkware and sirandreww-starkware).

---

a discussion (no related file):
Throughout the enitre PR: Dialling -> Dialing
We use American English (As long as libp2p allows us 😅 )

---

crates/apollo_network/src/discovery/mod.rs line 100 at r2 (raw file):

    /// Manages ongoing Kademlia queries for peer discovery.
    kad_requesting: KadRequestingBehaviour,
    /// Manages dialling to peers with exponential backoff.

I wouldn't state the exponential backoff here. How about // Manages dialing to peers with retries

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on guy-starkware and ShahakShama).

---

a discussion (no related file):

Previously, ShahakShama wrote…

Throughout the enitre PR: Dialling -> Dialing
We use American English (As long as libp2p allows us 😅 )

Done

---

crates/apollo_network/src/discovery/mod.rs line 100 at r2 (raw file):

Previously, ShahakShama wrote…

I wouldn't state the exponential backoff here. How about // Manages dialing to peers with retries

Done.

[ShahakShama]

@ShahakShama partially reviewed 5 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on guy-starkware).

[graphite-app]

Merge activity

• Mar 16, 1:34 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.