Skip to content

Fixed VirtualMCPCompositeToolDefinition printer columns output #5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisJBurns merged 4 commits into from
May 28, 2026
Merged

Fixed VirtualMCPCompositeToolDefinition printer columns output #5380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
206776a
Fixed VirtualMCPCompositeToolDefinition printer columns output
Sanskarzz May 25, 2026
5f18673
Improved coverage and fixed CI lint error
Sanskarzz May 26, 2026
47ae83f
Fixed Operator E2E CI failures
Sanskarzz May 26, 2026
672e093
removed malformed Steps and Refs printer column
Sanskarzz May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cmd/thv-operator/api/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,7 @@ type MCPToolConfigList struct {
//+kubebuilder:subresource:status
//+kubebuilder:resource:shortName=vmcpctd;compositetool,categories=toolhive
//+kubebuilder:printcolumn:name="Workflow",type="string",JSONPath=".spec.name",description="Workflow name"
//+kubebuilder:printcolumn:name="Steps",type="integer",JSONPath=".spec.steps[*]",description="Number of steps"
//+kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.validationStatus",description="Validation status"
//+kubebuilder:printcolumn:name="Refs",type="integer",JSONPath=".status.referencingVirtualServers[*]",description="Refs"
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
//+kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type=='Ready')].status"

Expand Down
2 changes: 0 additions & 2 deletions cmd/thv-operator/api/v1beta1/virtualmcpcompositetooldefinition_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,7 @@ const (
//+kubebuilder:subresource:status
//+kubebuilder:resource:shortName=vmcpctd;compositetool,categories=toolhive
//+kubebuilder:printcolumn:name="Workflow",type="string",JSONPath=".spec.name",description="Workflow name"
//+kubebuilder:printcolumn:name="Steps",type="integer",JSONPath=".spec.steps[*]",description="Number of steps"
//+kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.validationStatus",description="Validation status"
//+kubebuilder:printcolumn:name="Refs",type="integer",JSONPath=".status.referencingVirtualServers[*]",description="Refs"
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
//+kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type=='Ready')].status"

Expand Down
16 changes: 0 additions & 16 deletions ...ts/operator-crds/files/crds/toolhive.stacklok.dev_virtualmcpcompositetooldefinitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,10 @@ spec:
jsonPath: .spec.name
name: Workflow
type: string
- description: Number of steps
jsonPath: .spec.steps[*]
name: Steps
type: integer
- description: Validation status
jsonPath: .status.validationStatus
name: Status
type: string
- description: Refs
jsonPath: .status.referencingVirtualServers[*]
name: Refs
type: integer
- description: Age
jsonPath: .metadata.creationTimestamp
name: Age
Expand Down Expand Up @@ -431,18 +423,10 @@ spec:
jsonPath: .spec.name
name: Workflow
type: string
- description: Number of steps
jsonPath: .spec.steps[*]
name: Steps
type: integer
- description: Validation status
jsonPath: .status.validationStatus
name: Status
type: string
- description: Refs
jsonPath: .status.referencingVirtualServers[*]
name: Refs
type: integer
- description: Age
jsonPath: .metadata.creationTimestamp
name: Age
Expand Down
16 changes: 0 additions & 16 deletions ...rts/operator-crds/templates/toolhive.stacklok.dev_virtualmcpcompositetooldefinitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,10 @@ spec:
jsonPath: .spec.name
name: Workflow
type: string
- description: Number of steps
jsonPath: .spec.steps[*]
name: Steps
type: integer
- description: Validation status
jsonPath: .status.validationStatus
name: Status
type: string
- description: Refs
jsonPath: .status.referencingVirtualServers[*]
name: Refs
type: integer
- description: Age
jsonPath: .metadata.creationTimestamp
name: Age
Expand Down Expand Up @@ -434,18 +426,10 @@ spec:
jsonPath: .spec.name
name: Workflow
type: string
- description: Number of steps
jsonPath: .spec.steps[*]
name: Steps
type: integer
- description: Validation status
jsonPath: .status.validationStatus
name: Status
type: string
- description: Refs
jsonPath: .status.referencingVirtualServers[*]
name: Refs
type: integer
- description: Age
jsonPath: .metadata.creationTimestamp
name: Age
Expand Down
Loading