Fixed VirtualMCPCompositeToolDefinition printer columns output#5380
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5380 +/- ##
==========================================
- Coverage 68.81% 68.79% -0.02%
==========================================
Files 628 628
Lines 63900 63900
==========================================
- Hits 43971 43962 -9
- Misses 16669 16683 +14
+ Partials 3260 3255 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
beb1475 to
145a068
Compare
|
@Sanskarzz Looking at this, do we need another controller just for a printer column? It seems a bit overkill? |
|
@ChrisJBurns The reason I added the small reconciler is that the Kubernetes printer column JSONPath cannot compute array lengths. The existing Because That said, I agree it is more machinery than ideal for a display-only issue, but the approach was recommended in the issue description. If you prefer the lower-scope fix, I can simplify this PR to remove the broken |
|
@Sanskarzz Yeah I think removing them is probably better for us. I thought the change would have been possible without another Reconciler, but if not, I'm happy for you to remove the malformed columns instead |
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
e7f4ca9 to
672e093
Compare
|
Sounds good, thanks. I’ve removed the malformed |
|
Thanks @Sanskarzz , I'll get @jerm-dro to take a look at this internally as vMCP is his wheelhouse, hopefully we should be good to go. |
Summary
StepsandRefsprinter columns fromVirtualMCPCompositeToolDefinition.kubectl get virtualmcpcompositetooldefinitionsno longer renders broken integer columns.Fixes #4619
Type of change
Test plan
task operator-generate,task operator-manifests,task crdref-gen)go test ./cmd/thv-operator/api/v1alpha1 ./cmd/thv-operator/api/v1beta1 ./cmd/thv-operator/app -run '^$' -count=1)task lint)API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied, and the migration guidance is described above.Changes
cmd/thv-operator/api/v1beta1/virtualmcpcompositetooldefinition_types.goStepsandRefsprinter column markers.cmd/thv-operator/api/v1alpha1/types.goDoes this introduce a user-facing change?
Yes.
kubectl get virtualmcpcompositetooldefinitionsno longer shows the brokenStepsandRefscolumns. The remaining columns continue to render normally.Special notes for reviewers
Kubernetes CRD printer column JSONPath cannot compute array lengths. A count-based implementation would require scalar status fields plus reconciliation logic to keep them current. Per review feedback, this PR uses the lower-risk fix and removes the malformed display columns instead.