Skip to content

Add adapter close lifecycle #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuel-williams-shopify merged 3 commits into from
Sep 10, 2026
Merged

Add adapter close lifecycle #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6291566
Add adapter close lifecycle
samuel-williams-shopify Sep 10, 2026
ac6abcd
Keep adapter close independent of Rack application
samuel-williams-shopify Sep 10, 2026
bf326b5
Test adapter close contract
samuel-williams-shopify Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/protocol/rack/adapter/generic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ def initialize(app)
raise ArgumentError, "App must be callable!" unless @app.respond_to?(:call)
end

# Rack does not define an application lifecycle hook, so there is nothing to close.
def close
end

# The logger to use for this adapter.
#
# @returns [Console] The console logger.
Expand Down
10 changes: 10 additions & 0 deletions test/protocol/rack/adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@
expect(subject.parse_file(rackup_path)).to be_a(Proc)
end

with "#close" do
it "can be closed" do
app = ->(env){[200, {}, []]}
adapter = subject.new(app)

expect(adapter).to be(:respond_to?, :close)
expect(adapter.close).to be_nil
end
end

with ".make_response" do
let(:env) {Rack::MockRequest.env_for("/")}

Expand Down
Loading