Add adapter close lifecycle - #37
Merged
Merged
Conversation
Assisted-By: devx/b8194217-b20a-4799-b266-4910beb3ee2b
Assisted-By: devx/b8194217-b20a-4799-b266-4910beb3ee2b
Assisted-By: devx/b8194217-b20a-4799-b266-4910beb3ee2b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol::Rack::Adapter presents a Rack application as Protocol::HTTP middleware, whose lifecycle includes
#close. The adapter currently implements#callbut not#close, causing middleware shutdown to raise unless applications add their own adapter-level workaround.This change makes the adapter always respond to
#closeand forwards it when the underlying Rack application exposes an optional close hook.This was found while running Shopify Core through Falcon with
Protocol::HTTP::Executor::Threaded.Testing
bundle exec sus(148 tests, 311 assertions)