Skip to content

fix: resolve CodeQL code scanning security alerts #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shrijayan merged 3 commits into from
Mar 27, 2026
Merged

fix: resolve CodeQL code scanning security alerts #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0965ab2
fix: resolve CodeQL code scanning security alerts
shrijayan Mar 27, 2026
31c64a3
fix: revert getHubDir path validation that introduced CodeQL alerts
shrijayan Mar 27, 2026
e2a7ab4
fix: revert log sanitization that triggers CodeQL log-injection alert
shrijayan Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions packages/cli/src/pty-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,11 @@ export function getDefaultShell(): string {
* Inherits the current process env and sets TERM for proper terminal behavior.
*/
function buildEnv(): Record<string, string> {
const env: Record<string, string> = {};
for (const [key, value] of Object.entries(process.env)) {
if (value !== undefined) {
env[key] = value;
}
}
const env = Object.fromEntries(
Object.entries(process.env).filter(
(entry): entry is [string, string] => entry[1] !== undefined
)
);
// Set TERM for unix systems to enable color and cursor support
if (process.platform !== "win32") {
env["TERM"] = env["TERM"] || "xterm-256color";
Expand Down
7 changes: 5 additions & 2 deletions packages/hub/src/windows-firewall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ export class WindowsFirewall {
async addRule(label: string, port: number): Promise<{ success: boolean; error?: string }> {
if (!this.isWindows) return { success: true };

const ruleName = `${RULE_PREFIX}-${label}`;
// Sanitize label to prevent log/command injection
const safeLabel = label.replace(/[^a-zA-Z0-9._-]/g, "_").slice(0, 64);
const ruleName = `${RULE_PREFIX}-${safeLabel}`;

// Skip if already tracked
if (this.rules.has(ruleName)) return { success: true };
Expand Down Expand Up @@ -70,7 +72,8 @@ export class WindowsFirewall {
async removeRule(label: string): Promise<void> {
if (!this.isWindows) return;

const ruleName = `${RULE_PREFIX}-${label}`;
const safeLabel = label.replace(/[^a-zA-Z0-9._-]/g, "_").slice(0, 64);
const ruleName = `${RULE_PREFIX}-${safeLabel}`;
await this.runNetsh([
"advfirewall", "firewall", "delete", "rule",
`name=${ruleName}`,
Expand Down
7 changes: 7 additions & 0 deletions scripts/sync-versions.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ if (!version) {
process.exit(1);
}

// Validate semver format to prevent injection via crafted version strings
const SEMVER_RE = /^\d+\.\d+\.\d+(-[\w.]+)?(\+[\w.]+)?$/;
if (!SEMVER_RE.test(version)) {
console.error(`Invalid version format: "${version}". Expected semver (e.g. 1.2.3).`);
process.exit(1);
}

const packagesDir = join(import.meta.dirname, "..", "packages");
const packages = readdirSync(packagesDir, { withFileTypes: true })
.filter((d) => d.isDirectory())
Expand Down
Loading