fix: resolve CodeQL code scanning security alerts#97
Merged
Conversation
Owner
shrijayan
commented
Mar 27, 2026
shrijayan
commented
- Validate ITWILLSYNC_CONFIG_DIR env var (path injection, CWE-22)
- Use Object.fromEntries for env copy (property injection, CWE-94)
- Sanitize firewall rule labels and log messages (log injection, CWE-117)
- Validate port range in CLI arg parsing (input validation, CWE-20)
- Validate semver format in version sync script (input validation, CWE-20)
- Validate ITWILLSYNC_CONFIG_DIR env var (path injection, CWE-22) - Use Object.fromEntries for env copy (property injection, CWE-94) - Sanitize firewall rule labels and log messages (log injection, CWE-117) - Validate port range in CLI arg parsing (input validation, CWE-20) - Validate semver format in version sync script (input validation, CWE-20)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The path validation added to getHubDir() expanded the taint surface for CodeQL, introducing 34 new alerts instead of fixing existing ones. For a local CLI tool, env vars and CLI args are user-controlled by design. Retains: log injection fix, label sanitization, semver validation, buildEnv refactor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Error messages in a local CLI tool are not user-controlled attack vectors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.