Update ROS 2 API usage in usb_cam_node - #388
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
This upstreams the ROS 2 API compatibility portion of the RoboStack usb_cam patch. image_transport::create_camera_publisher now accepts a node reference and QoS directly, and CameraInfoManager can be constructed from the node interfaces used by rclcpp::Node. Updating these calls keeps the node compatible with current ROS 2 APIs without carrying the unrelated warning-policy and FFmpeg hunks from the downstream patch. Origin: patch/ros-rolling-usb-cam.patch, authored by Daisuke Nishimatsu. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Author
|
FYI @wep21 and @traversaro: I opened this while upstreaming RoboStack patches tracked in RoboStack/robostack.github.io#16. This one comes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to contribute RoboStack downstream patches back upstream.
Origin:
patch/ros-rolling-usb-cam.patch, authored by Daisuke Nishimatsu.This updates two
usb_cam_nodecalls to the current ROS 2 APIs used byimage_transportandcamera_info_manager. The RoboStack patch also includes warning-policy and FFmpeg compatibility changes, but this PR keeps the ROS 2 API compatibility changes separate.