fix(launch): resolve Pydantic v2 compatibility and update build instructions - #387
Open
jwsung91 wants to merge 1 commit into
Open
fix(launch): resolve Pydantic v2 compatibility and update build instructions#387jwsung91 wants to merge 1 commit into
jwsung91 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses two main issues related to building and launching the
usb_campackage on newer environments (specifically ROS 2 Jazzy on Ubuntu 24.04):Pydantic v2 Compatibility:
@root_validator) used inlaunch/camera_config.py.launch/camera_config.pyto import frompydantic.v1with a fallback topydantic. This maintains backward compatibility with ROS 2 Humble/Pydantic v1 while fixing the crash on ROS 2 Jazzy.Build and Sourcing Documentation:
README.mdto explicitly guide users through sourcing their ROS 2 installation.rosdepif it is missing on the system.${ROS_DISTRO}for convenience.Type of Change
How Has This Been Tested?
colcon build).ros2 launch usb_cam camera.launch.pystarts correctly without throwing Pydantic-related Python exceptions.