Skip to content

fix(health): reword stale_governance text to match what the finding c… #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macholul wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(health): reword stale_governance text to match what the finding c… #4391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/repowise/core/analysis/health/fix_first/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def history_fact(marker: str, details: dict, function: str | None = None) -> str
if marker == "code_age_volatility":
return "old code that still changes often"
if marker == "stale_governance":
return "a decision that covers it is out of date"
return "a decision that covers it predates changes to the files it governs"
if marker == "contradictory_decision":
return "decisions that cover it disagree"
return None
Expand Down
8 changes: 4 additions & 4 deletions packages/core/src/repowise/core/analysis/health/suggestions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,10 @@
"to check against."
),
"stale_governance": (
"The architectural decision governing this file has gone stale: "
"the code has changed but the decision hasn't been reviewed. "
"Update or supersede the decision via `repowise decision edit` "
"so the rationale reflects the current implementation."
"Files governed by this file's architectural decision have changed "
"since the decision was recorded. Review it, and if it no longer "
"holds, update or supersede it via `repowise decision edit` so the "
"rationale reflects the current implementation."
),
"contradictory_decision": (
"Two active decisions make contradictory claims that affect this "
Expand Down
7 changes: 7 additions & 0 deletions packages/ui/__tests__/health/biomarker-glossary.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { describe, expect, it } from "vitest";
import {
CATEGORY_CAP,
PERFORMANCE_HOME_BIOMARKERS,
biomarkerInfo,
biomarkerLabel,
isKnownBiomarker,
} from "../../src/health/biomarker-glossary.js";
Expand Down Expand Up @@ -45,3 +46,9 @@ describe("performance glossary", () => {
expect(missing).toEqual([]);
});
});

describe("stale_governance description", () => {
it("claims only what the finding checks, not that anyone confirmed the decision", () => {
expect(biomarkerInfo("stale_governance").description).not.toMatch(/confirmed/i);
});
});
2 changes: 1 addition & 1 deletion packages/ui/src/health/biomarker-glossary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export const BIOMARKER_GLOSSARY: Record<string, BiomarkerInfo> = {
label: BIOMARKER_LABELS.stale_governance,
category: "organizational",
description:
"The architectural decision governing this file has gone stale — the code has moved on since the decision was last confirmed.",
"Files governed by this file's architectural decision have changed since the decision was recorded. The decision may still hold, but it is worth a review.",
},
contradictory_decision: {
label: BIOMARKER_LABELS.contradictory_decision,
Expand Down
Loading