Repository navigation
Conversation
Contributor
|
Reviewed the whole diff: nothing to fix. ✅ Health of changed files: 8.5 → 8.9 (+0.4; structure +0.8)
Doc drift
🧾 Evidence: 6 not known
👀 Suggested reviewers @RaghavChamadiya 📊 See the full report for this PR Settings and updatesUpdated 2026-10-22 05:29 UTC |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stale_governancetext in three places so it claims only what the finding checks: that files the decision governs changed after the decision was recorded, and that it is worth a review. It no longer says the decision was "last confirmed" or "out of date".biomarker-glossary.ts), the suggestion template (suggestions.py) and the fix-first reason text (fix_first/text.py).hygiene.pyis left alone since fix(decisions): measure staleness from the commit that landed a decision #4357 rewords it.Related Issues
Fixes #4385
Test Plan
Added a glossary test asserting the
stale_governancedescription no longer says "confirmed". It fails on the old wording and passes on the new.UI health tests pass, and
tsc --noEmitis clean.ruff checkis clean on the changed Python files.Python unit tests, including
tests/unit/health/test_governance.py, are left to CI. No logic changed, only string literals.Tests pass (
pytest)Lint passes (
ruff check .)Web build passes (
npm run build) (if frontend changes)Checklist