Skip to content

fix(health): reword stale_governance text to match what the finding c… - #4391

Open
macholul wants to merge 1 commit into
repowise-dev:mainfrom
macholul:fix/stale-governance-wording
Open

macholul wants to merge 1 commit into
repowise-dev:mainfrom
macholul:fix/stale-governance-wording

Conversation

@macholul

Copy link
Copy Markdown

Summary

  • Rewords the stale_governance text in three places so it claims only what the finding checks: that files the decision governs changed after the decision was recorded, and that it is worth a review. It no longer says the decision was "last confirmed" or "out of date".
  • Places changed: the glossary description (biomarker-glossary.ts), the suggestion template (suggestions.py) and the fix-first reason text (fix_first/text.py).
  • No change to scoring, severity, marker name or label. hygiene.py is left alone since fix(decisions): measure staleness from the commit that landed a decision #4357 rewords it.

Related Issues

Fixes #4385

Test Plan

  • Added a glossary test asserting the stale_governance description no longer says "confirmed". It fails on the old wording and passes on the new.

  • UI health tests pass, and tsc --noEmit is clean.

  • ruff check is clean on the changed Python files.

  • Python unit tests, including tests/unit/health/test_governance.py, are left to CI. No logic changed, only string literals.

  • Tests pass (pytest)

  • Lint passes (ruff check .)

  • Web build passes (npm run build) (if frontend changes)

Checklist

  • My code follows the project's code style
  • I have added tests for new functionality
  • All existing tests still pass
  • I have updated documentation if needed

@repowise-bot

repowise-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Reviewed the whole diff: nothing to fix.

✅ Health of changed files: 8.5 → 8.9 (+0.4; structure +0.8)
Average full file score (structure and history) of 4 changed code files, weighted by size before this PR; not the repository score.

Check Result
Coverage Waiting for this PR's CI to upload a report (last report from this repo 4 minutes ago)
Tests 3 of 3 changed code files reached by a test · which tests
Security No new findings on changed lines
Doc drift No drift in docs this PR edits · 1 document name changed files
Doc drift
  • packages/core/src/repowise/core/analysis/health/README.md names packages/core/src/repowise/core/analysis/health/suggestions.py, packages/ui/src/health/biomarker-glossary.ts and is not in this PR
🧾 Evidence: 6 not known
Item Status Evidence
Components touched ok · inferred 1 component: packages
Declared owners ok · declared @RaghavChamadiya, @swati510
Suggested reviewers unknown · not known Not known: not gathered on a pull request
Tests reaching the change unknown · not known 0 of 3 changed files reached by a test; 3 not known
Contracts touched ok · measured No workspace contract touched; no breaking signature change
Consumers in other repos unknown · not known Not known: not gathered on a pull request
Decisions crossed unknown · not known Not known: decision records are read only for an AI review
Health delta ok · measured Findings: 0 introduced, 0 worsened, 0 resolved
AI provenance unknown · not known Provenance: unknown, known for 0 of 1 commit; AI share withheld: coverage 0% is below 30%
Diff size rank ok · measured Larger than 7.5% of recent commits
Outcomes since merge unknown · not known Not known: a pull request is not a merged change

👀 Suggested reviewers @RaghavChamadiya


📊 See the full report for this PR
Blast radius, every caller of the contracts it changes, and health before and after. No sign-in.
Reviewed with AI · Plain markdown for agents

Settings and updates

Updated 2026-10-22 05:29 UTC
Silence one PR with [skip repowise] in the title · Bot settings
⭐ Star Repowise · 📥 Install on another repo

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The stale_governance description says the code moved on since the decision was last confirmed, which the finding does not check

1 participant