Repository navigation
Conversation
…n uses
Port rehosting/qemu 862d4fb74f (#22), which penguin main now depends on:
plugins.qmp.emit_event() pushes an unsolicited QMP event of any name to
every connected monitor, the counterpart to the QMP command callback.
Without it, penguin cannot move from the fork to this repo without losing
that API.
Following the repo's split, only the edit to an upstream file is a patch:
* 0013 adds monitor/penguin-event.c to the qmp source set;
* src/monitor/penguin-event.c is the emitter, vendored;
* src/include/system/penguin.h declares it and
src/scripts/penguin-cffi-gen.py exposes it through the CFFI header.
penguin.h and penguin-cffi-gen.py are byte-identical to the fork's. The
emitter needed one port: the fork predates QEMU 11.1, where monitors became
QOM objects, monitor_is_qmp() is gone and MonitorQMP no longer embeds a
"common" Monitor. It now finds QMP monitors with
object_dynamic_cast(..., TYPE_MONITOR_QMP), the idiom monitor/qmp.c uses.
check-delta-present.sh now asserts the symbol in every system library.
The series applies 13/13 with strict context; patchedTree re-recorded;
the import/export round trip is clean. nix build of penguin-qemu builds
all 14 system libraries and check-delta-present passes.
Co-authored-by: Benjamin Levy <153011444+be32826@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n uses
Port rehosting/qemu 862d4fb74f (#22), which penguin main now depends on: plugins.qmp.emit_event() pushes an unsolicited QMP event of any name to every connected monitor, the counterpart to the QMP command callback. Without it, penguin cannot move from the fork to this repo without losing that API.
Following the repo's split, only the edit to an upstream file is a patch:
object_dynamic_cast(..., TYPE_MONITOR_QMP), the idiom monitor/qmp.c uses. check-delta-present.sh now asserts the symbol in every system library.
The series applies 13/13 with strict context; patchedTree re-recorded; the import/export round trip is clean. nix build of penguin-qemu builds all 14 system libraries and check-delta-present passes.