Repository navigation
Conversation
Two patches (0013-0014), both upstream candidates: - hw/char/serial: retry a byte left pending at savevm when the chardev can't be watched at load time (a socket server with no client yet). Before, the transmitter stayed busy forever and the guest console was dead after the restore. - target/arm: savevm/loadvm dropped the Secure bank of AArch32 cp registers on TCG CPUs with EL3 (kvm_to_cpreg_id() forces the NS bit), so a guest running in Secure state faulted right after a restore. verify-series: 14/14 apply with strict context to pristine qemu-11.1.0; patchedTree recorded; the import/export round trip is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two savevm/loadvm bugs, as patches 0013-0014. Both are upstream candidates.
(for example a socket server with no client yet). Before this fix the transmitter stayed busy forever, and the
guest console was dead after the restore. A one-shot BH now retries:
serial_xmit()either sends the byte,installs a watch, or drops the byte at the retry limit.
kvm_to_cpreg_id()forces the NS bit, so the Secure-bank registers (DACR_S, TTBR1_S, ...) were never saved,and on load the Non-secure values overwrote them.
cpreg_list_id_to_cpreg_id()is the exact inverse ofcpreg_to_kvm_id(). For AArch64 (KVM) ids it is identical tokvm_to_cpreg_id().Note: snapshots taken before this fix stored Non-secure values in the Secure slots. Loading them now writes
those values into the Secure bank. Such snapshots were already broken for guests running in Secure state.
verify-series: 14/14 apply with strict context to pristine qemu-11.1.0. patchedTree is recorded, and the
import/export round trip is clean.
Ordering: PR #4 and the panda-next stack also use slot 0013 and also change base.json. Whichever lands later
renumbers (export-series does this) and re-records patchedTree.