Skip to content

Support SelectableParagraph in fantom tester #59210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Abbondanzo wants to merge 1 commit into from
+6 −1
Closed

Support SelectableParagraph in fantom tester #59210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion private/react-native-fantom/tester/src/render/RenderOutput.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ folly::dynamic RenderOutput::renderView(
folly::dynamic props = folly::dynamic::object;
#endif

if (std::string_view(view.componentName) == "Paragraph") {
// SelectableParagraph shares ParagraphState with Paragraph; render its text
// the same way so selectable text stays observable in test output.
if (std::string_view(view.componentName) == "Paragraph" ||
std::string_view(view.componentName) == "SelectableParagraph") {
const auto& state =
static_cast<const ConcreteState<ParagraphState>&>(*view.state);
element["children"] =
Expand Down
2 changes: 2 additions & 0 deletions private/react-native-fantom/tester/src/stubs/StubComponentRegistryFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <react/renderer/components/scrollview/ScrollViewComponentDescriptor.h>
#include <react/renderer/components/text/ParagraphComponentDescriptor.h>
#include <react/renderer/components/text/RawTextComponentDescriptor.h>
#include <react/renderer/components/text/SelectableParagraphComponentDescriptor.h>
#include <react/renderer/components/text/TextComponentDescriptor.h>
#include <react/renderer/components/view/ViewComponentDescriptor.h>

Expand All @@ -29,6 +30,7 @@ inline ComponentRegistryFactory getDefaultComponentRegistryFactory()
providerRegistry->add(concreteComponentDescriptorProvider<ParagraphComponentDescriptor>());
providerRegistry->add(concreteComponentDescriptorProvider<ScrollViewComponentDescriptor>());
providerRegistry->add(concreteComponentDescriptorProvider<RawTextComponentDescriptor>());
providerRegistry->add(concreteComponentDescriptorProvider<SelectableParagraphComponentDescriptor>());
providerRegistry->add(concreteComponentDescriptorProvider<TextComponentDescriptor>());
providerRegistry->add(concreteComponentDescriptorProvider<ViewComponentDescriptor>());
providerRegistry->add(concreteComponentDescriptorProvider<ModalHostViewComponentDescriptor>());
Expand Down
Loading