Repository navigation
Support SelectableParagraph in fantom tester - #59210
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: The fantom test renderer only rendered text children for Paragraph nodes and its stub component registry did not register the SelectableParagraph descriptor, so selectable text fell back to an unimplemented view with empty output. Register the SelectableParagraph descriptor and render its children from ParagraphState the same way as Paragraph, so selectable text stays observable in test output. Changelog: [Internal] Differential Revision: D126186990
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126186990. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in f1f516e When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in f1f516e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The fantom test renderer only rendered text children for Paragraph nodes and
its stub component registry did not register the SelectableParagraph
descriptor, so selectable text fell back to an unimplemented view with empty
output. Register the SelectableParagraph descriptor and render its children
from ParagraphState the same way as Paragraph, so selectable text stays
observable in test output.
Changelog: [Internal]
Differential Revision: D126186990