Skip to content

[PR #2595/5010124a backport][2.24] fix: copy request headers before adding auth - #2611

Merged
gerrod3 merged 2 commits into
2.24from
patchback/backports/2.24/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595
Oct 27, 2026
Merged

gerrod3 merged 2 commits into
2.24from
patchback/backports/2.24/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Conversation

@patchback

@patchback patchback Bot commented Oct 27, 2026

Copy link
Copy Markdown

This is a backport of PR #2595 as merged into main (5010124).

Assisted By: Claude Opus 5

extra_data["headers"] is usually the V2_ACCEPT_HEADERS constant, and headers.update(auth_headers) mutated it in place. The first token negotiated in a process leaked into every later request, including those to other registries.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Assisted By: Claude Opus 5

extra_data["headers"] is usually the V2_ACCEPT_HEADERS constant, and
headers.update(auth_headers) mutated it in place. The first token
negotiated in a process leaked into every later request, including
those to other registries.

(cherry picked from commit 5010124)

@gerrod3 gerrod3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the backport of #2595. The header copy fix and changelog entry apply cleanly.

@gerrod3
gerrod3 merged commit 7a8fd82 into 2.24 Oct 27, 2026
14 checks passed
@gerrod3
gerrod3 deleted the patchback/backports/2.24/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595 branch October 27, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants