Skip to content

fix: copy request headers before adding auth - #2595

Merged
gerrod3 merged 1 commit into
pulp:mainfrom
am9zZWY:fix/copy-request-headers
Oct 27, 2026
Merged

gerrod3 merged 1 commit into
pulp:mainfrom
am9zZWY:fix/copy-request-headers

Conversation

@am9zZWY

@am9zZWY am9zZWY commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Assisted By: Claude Opus 5

extra_data["headers"] is usually the V2_ACCEPT_HEADERS constant, and headers.update(auth_headers) mutated it in place. The first token negotiated in a process leaked into every later request, including those to other registries.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Assisted By: Claude Opus 5

extra_data["headers"] is usually the V2_ACCEPT_HEADERS constant, and
headers.update(auth_headers) mutated it in place. The first token
negotiated in a process leaked into every later request, including
those to other registries.
@gerrod3
gerrod3 merged commit 5010124 into pulp:main Oct 27, 2026
14 checks passed
@patchback

patchback Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Backport to 2.19: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.19/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Backported as #2610

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Backport to 2.26: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.26/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Backported as #2609

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Backport to 2.22: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.22/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Backported as #2608

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Backport to 2.20: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.20/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Backported as #2607

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Backport to 2.24: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.24/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Backported as #2611

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Backport to 2.27: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.27/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Backported as #2612

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Backport to 2.29: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.29/5010124a3efacdef0b5a4dc9a077c3273f14f86f/pr-2595

Backported as #2613

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants