Repository navigation
fix: v0.21.1 upgrade compatibility and install docs - #442
Merged
Merged
Conversation
- Migration 0051_simulate_run_effective_nullable drops NOT NULL from simulate_runs.effective_duration_seconds (the 1..120 CHECK stays), so a v0.20 pod's run insert works during a rolling upgrade and after a rollback. GetSimulateRunByID, ClaimQueuedSimulateRun and CreateSimulateRun select COALESCE(effective, requested); the worker and GetRun see the requested duration for such a run. Down backfills and restores NOT NULL. - UPGRADING 0.24.x -> 0.25.0: step 6 and Rolling back describe the 0.25.0 window and the 0.25.1 fix. - NOTES: token command execs through svc/<fullname>, not deploy/. - Kubernetes docs: preflight with the new image; strict-org reload cases. - README, site, Collectors docs and Connect a cluster dialog: org-bound agent tokens at Access -> Agent Tokens and who claims the cluster. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TAAVzyeV4HSSNjU8xVWWtE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TAAVzyeV4HSSNjU8xVWWtE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
v0.21.1 fixes from the post-release docs review (Part 0, items 0.1–0.4).
Migration 0051 (rolling-upgrade / rollback compatibility)
Migration 0050 made
simulate_runs.effective_duration_secondsNOT NULLwith no default. v0.20'sCreateSimulateRuninserts only(org_id, graph, requested_duration_seconds, created_by), so a v0.20 pod could not create a sandbox run on the migrated schema (SQLSTATE 23502). That happens during a rolling upgrade and afterhelm rollback.0051_simulate_run_effective_nullable:DROP NOT NULL. The 1..120 CHECK stays. The down migration backfills NULLs fromrequested_duration_seconds, thenSET NOT NULL. 0050 is not edited.GetSimulateRunByID,ClaimQueuedSimulateRunandCreateSimulateRunselectCOALESCE(effective_duration_seconds, requested_duration_seconds)::int.CompleteSimulateRunreturns onlyid, org_id, which is all its caller reads. sqlc was regenerated. The worker andsimulateRunToPrototake the per-query row types, so the simulator,GetRunand MCP (which reads GetRun's proto) all get the coalesced value.internal/store/simulate_run_effective_nullable_migration_test.go: a v0.20-shaped insert succeeds and reads back with effective = requested through Get and Claim; the CHECK still holds; the up/down round trip backfills and restores NOT NULL.GetRunreports effective = requested for that row.Docs and chart notes
UPGRADING.md0.24.x → 0.25.0: step 6 and Rolling back no longer claim old pods ignore 0050. They now say what chart 0.25.0 does (v0.20 pods cannot start sandbox runs until all pods run v0.21) and that 0.25.1 removes this. Operators should upgrade straight to 0.25.1, and rollback works after 0051.NOTES.txt: the token command now useskubectl exec -n <ns> svc/<fullname> -- shepherd token create ….deploy/could land on a simulator or receiver pod. Pinned by a new chart_hardening spec.kubernetes.html0.25/0.24 notes: run the new image's preflight against a database copy migrated with that image, or from a server pod right after the upgrade. Also notes that strict orgs reload once in two documented cases.site/index.html,collectors.htmlandConnectClusterDialognow describe org-bound tokens. They are minted at Access → Agent Tokens. An app admin's token claims the cluster on the first poll. An org admin's token is served only for a cluster an app admin has already claimed. The mocked UI spec asserts the new copy.### Fixedunder Unreleased.Testing
go test ./internal/store/... ./internal/simulate/... ./internal/mgmtapi/... ./internal/mcp/... ./internal/migrations/... ./deploy/helm/...make lint(0 issues, guards OK)make web-ci,make test-ui(664 passed)make helm-lint,go test ./scripts/repocheck/make docs,make check-docs-drift,make check-docs-version./scripts/build-web.shrun andinternal/spa/dist/staged (SPA copy changed)sqlc generaterun and output committed (SQL changed; no proto change)make testnot run; ran the affected packages listed above🤖 Generated with Claude Code
https://claude.ai/code/session_01TAAVzyeV4HSSNjU8xVWWtE