Skip to content

Expire stale carried finding evidence#104

Closed
morgaesis wants to merge 4 commits into
mainfrom
codex/fix-stale-carried-findings
Closed

Expire stale carried finding evidence#104
morgaesis wants to merge 4 commits into
mainfrom
codex/fix-stale-carried-findings

Keep synthesis from retiring prior findings

6155d52
Select commit
Loading
Failed to load commit list.
postil-dev / postil/review succeeded Jul 20, 2026 in 2m 31s

0 error, 2 warn, 0 info

info 2 new advisory findings

Review details

Annotations

Check warning on line 761 in src/diff.rs

See this annotation in the file changed.

@postil-dev postil-dev / postil/review

Old-coordinate check uses wrong path for renamed files

rendered_old_coordinates is populated at line 595 with (current_path, number) where current_path is the new/head path from the rendering loop. contains_reviewed_baseline_coordinate checks that set with (finding.path, finding.line) at line 758, but finding.path is the baseline's old path. For a renamed file the old path is not in rendered_old_coordinates, so the old-coordinate branch always returns false and the method falls through to the current-coordinate check, which only matches by line-number coincidence. The practical effect is that baseline findings on renamed files cannot be retired via the old-coordinate path even when the review actually saw that coordinate. Fix: also check rendered_old_coordinates with current_path (the renamed_paths lookup already computed at line 762-765), or store old coordinates keyed by old_path.

Check warning on line 2478 in tests/e2e.rs

See this annotation in the file changed.

@postil-dev postil-dev / postil/review

Review exit code changed from 1 to 0 despite error finding in fixture

The bounded-review test still seeds a baseline with an error-severity finding (line 2455, severity "error", confidence 0.9) but now asserts exit code 0 instead of 1. If carried prior findings no longer trigger a non-zero exit, callers or CI that gate on the CLI exit code will silently pass reviews that previously failed. Verify the intended behavior: confirm that carried error findings should not fail the review, and check every consumer of the exit code to ensure it still matches.