Expire stale carried finding evidence#104
Conversation
![postil-dev[bot]](https://avatars.githubusercontent.com/in/3455612?s=60&v=4){kind=small}
| review_trust = if batch_failed { | ||
| filter::ReviewTrust::Failed | ||
| } else if risk_selected_review { | ||
| filter::ReviewTrust::Bounded | ||
| } else { | ||
| filter::ReviewTrust::Exhaustive | ||
| }; |
There was a problem hiding this comment.
warn · confidence 0.82 · kind: humanEscalation
The old code set full_review_trustworthy=false for bounded reviews, which carried prior findings forward and kept the gate failing. The new code assigns ReviewTrust::Bounded and the updated e2e test confirms prior findings from non-selected batches are now moved to resolved with gate.failing=false (tests/e2e.rs lines 2457, 2466-2468, 2480, 2488-2489). This means a real issue in a file outside the bounded-review selection is silently resolved and no longer blocks the merge. Confirm with the review-policy owner that auto-resolving out-of-scope prior findings is intended, and verify the reconcile implementation only expires findings whose cited lines are truly absent from the complete current diff, not merely absent from the selected batch.
| .args(["--output", "json"]) | ||
| .assert() | ||
| .code(1); | ||
| .code(0); |
There was a problem hiding this comment.
warn · confidence 0.72 · kind: humanEscalation
The test was renamed from carrying changed prior findings to expiring them, and the expected exit code changed from 1 to 0, confirming that prior findings from batches outside the bounded selection are no longer carried forward. Users who rely on bounded reviews will silently lose baseline findings for files not in the current selection. Confirm with the product owner that expiring rather than carrying these findings is the intended behavior, and verify that the reconcile path in src/filter.rs line 292 (trust == ReviewTrust::Exhaustive) correctly gates this for both bounded and full review scopes.
|
Superseded by #105, which contains the same reviewed fix plus the renamed-evidence regression on a clean PR baseline. |
|
@postil approve 6d3927b16f3b8f60c7fb78a24bd40e836d2cb94563019a966bee44096391ea70 -- Reviewed the bounded-review evidence lifecycle and accept this scoped compatibility tradeoff. |
1 similar comment
|
@postil approve 6d3927b16f3b8f60c7fb78a24bd40e836d2cb94563019a966bee44096391ea70 -- Reviewed the bounded-review evidence lifecycle and accept this scoped compatibility tradeoff. |
1 participant
Separate failed, bounded, and exhaustive review trust so completed bounded reviews expire changed or removed citations without dropping unchanged evidence outside the selected batches. Exact evidence remapping now covers duplicate lines and renames, with full and incremental regressions; the package version is 0.7.7 for the corrective release.