Conversation
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full |
PR Summary by QodoHandle empty JSON Lines during header discovery
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Coverage Report for CI Build 35119054967Coverage increased (+0.02%) to 92.081%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fromjson(path, lines=True)raisesRuntimeError: generator raised StopIterationfor an empty file when no header is supplied. This also prevents reading the empty JSON Lines file produced bytojson([('id',)], path, lines=True).Catch exhaustion during header discovery and yield an empty header tuple, matching an empty
fromdicts([])table. Explicit headers remain intact. Blank lines and malformed records still raise errors rather than being silently skipped.Changes
iterjlineswithout changing the JSON array reader.Validation
Windows / Python 3.12.14, current master
9a0b8448228b2575713dce93dacfc8451a4152b9:RuntimeError.python -m pytest petl -q --tb=short: 598 passed, 16 skipped.Checklist
643675d, including the OS/Python matrix and documentation tests. CodeQL and Read the Docs also passed.No new public function is introduced.