Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions schema/clawsweeper-decision.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,8 @@
"confidenceScore",
"file",
"lineStart",
"lineEnd"
"lineEnd",
"lateFinding"
],
"properties": {
"title": {
Expand Down Expand Up @@ -544,7 +545,7 @@
},
"lateFinding": {
"type": "boolean",
"description": "True when this finding targets code unchanged since an earlier reviewed head where the concern was equally visible but was not raised. Omit or use false for findings introduced by new commits or newly available evidence."
"description": "True when this finding targets code unchanged since an earlier reviewed head where the concern was equally visible but was not raised. Use false for findings introduced by new commits or newly available evidence."
}
}
}
Expand Down
7 changes: 7 additions & 0 deletions test/review-prompt-policy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,13 @@ test("decision schema keeps draft and protected workflow state out of PR rank",
);
});

test("review finding schema requires every structured-output property", () => {
const schema = JSON.parse(readFileSync("schema/clawsweeper-decision.schema.json", "utf8"));
const finding = schema.properties.reviewFindings.items;

assert.deepEqual([...finding.required].sort(), Object.keys(finding.properties).sort());
});

test("review prompt and schema describe positive-only feature showcase labels", () => {
const prompt = readFileSync("prompts/review-item.md", "utf8");
const schema = JSON.parse(readFileSync("schema/clawsweeper-decision.schema.json", "utf8"));
Expand Down