fix(review): require late-finding schema field#404
Conversation
|
ClawSweeper review: did not complete due to Codex infrastructure failure. Reviewed July 4, 2026, 3:45 AM ET / 07:45 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness This is a ClawSweeper/Codex infrastructure failure, not a PR readiness or patch-quality verdict. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against f4bc90093196. Evidence reviewedWhat I checked:
Likely related people:
How this review workflow works
|
|
Land-ready proof for
This repairs the strict Responses API schema rejection observed in live review records. I’ll verify the production review path immediately after deployment. |
What Problem This Solves
The live exact-item review for #341 failed twice immediately after #384 landed. The Responses API rejected
schema/clawsweeper-decision.schema.jsonbecausereviewFindings[].lateFindingwas present inpropertiesbut absent from that object'srequiredarray.Observed production error:
Why This Change Was Made
OpenAI strict structured outputs require every object property to appear in
required. This addslateFindingto the required list and tells the model to emitfalsewhen the finding is not late.The regression test compares the finding object's complete property set with its required set, so adding another optional-looking property cannot silently break every review again.
User Impact
ClawSweeper reviews can reach the model again. Runtime parsing remains backward-tolerant, while model output now always supplies a boolean
lateFindingvalue.Evidence
Exact head:
2d352da39cLive failure evidence: #341's durable review record shows
invalid_json_schemawithMissing 'lateFinding'at exact headbae964f9611a3cf470158966e95a034f0ec7b30a.