fix: reduce redundant apply continuation runs#400
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 3, 2026, 9:23 PM ET / 01:23 UTC. Summary Reproducibility: no. high-confidence live reproduction was established because running apply continuations could mutate GitHub state. Source inspection shows current main queues a fresh apply workflow whenever APPLY_CONTINUE is true, while this PR adds a same-target active-run sharing guard. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge the narrow continuation guard only after redacted live Actions/runtime proof or an explicit maintainer override confirms default cursor sharing works while explicit and non-default apply dispatches remain exact. Do we have a high-confidence way to reproduce the issue? No high-confidence live reproduction was established because running apply continuations could mutate GitHub state. Source inspection shows current main queues a fresh apply workflow whenever APPLY_CONTINUE is true, while this PR adds a same-target active-run sharing guard. Is this the best way to solve the issue? Yes, the implementation direction is narrow and keeps explicit/non-default continuations dispatching with their exact inputs. It still needs live proof or maintainer override because the active-run predicate controls production Actions dispatch. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ead7d6461a6c. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
77ec2e6 to
9829424
Compare
9829424 to
c1150ec
Compare
|
Land-ready at exact head Maintainer fixups on top of the contributor work:
Local proof: Fresh whole-branch autoreview: no actionable findings; patch correct at 0.86 confidence. Hosted exact-head proof:
GitHub's documented workflow-run status filters and a live ClawSweeper API response confirm the queried active statuses plus Known proof gap: the natural scheduled cadence must run from |
What Problem This Solves
Default cursor-based apply runs can queue redundant continuations while another default apply run for the same repository is already active. That adds Actions noise and competes with useful apply-health signals. A custom or exact-item apply run must not suppress the default cursor lane because it does not advance the same work.
Why This Change Was Made
This PR makes continuation ownership explicit:
User Impact
Maintainers get fewer redundant default apply runs and clearer run titles without delaying custom or exact-item work. If no matching live default run exists, the workflow keeps the existing continuation dispatch behavior.
Evidence
Maintainer proof at head
c1150ec26b461907f7bc3d4a1443130b902bd22e:actionlintaccepts the new continuation path and run-title expression. Its only findings are two pre-existing shellcheck warnings elsewhere insweep.yml.GitHub's workflow-runs API documents all queried active statuses (
in_progress,queued,requested,waiting, andpending) and exposespathplusdisplay_title: https://docs.github.com/en/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Live ClawSweeper run28695873174returned.github/workflows/sweep.ymlas the path and a target-specific display title.Fresh whole-branch autoreview returned no actionable findings and rated the patch correct at 0.86 confidence.
Exact-head hosted proof is green:
pnpm checkand Windows launcher): https://github.com/openclaw/clawsweeper/actions/runs/28696138014Live Validation Plan
After merge, observe the natural scheduled apply cadence rather than dispatching a destructive apply run manually. Verify target-specific default titles, continuation logs, and absence of overlapping same-target default continuations. Custom and exact-item behavior is covered deterministically by the focused tests.
Risk
Moderate workflow risk, bounded to continuation admission and run titles. On lookup or parse failure the continuation step fails visibly; it does not silently suppress work. No close, label, review, or repair policy changes are included.