fix: surface apply health on dashboard#391
Conversation
|
Codex review: needs changes before merge. Reviewed July 3, 2026, 9:05 PM ET / 01:05 UTC. Summary Reproducibility: not applicable. as a feature/operations PR. The branch demonstrates the changed behavior with direct JSON proof, inspected dashboard screenshots, and a successful production Worker smoke run; the only source-level concern is visible in CHANGELOG.md. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Security Review findings
Review detailsBest possible solution: Remove the CHANGELOG.md entry, keep release-note context in the PR body or commit message, then merge if maintainers accept the apply telemetry workflow risk after required checks finish. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature/operations PR. The branch demonstrates the changed behavior with direct JSON proof, inspected dashboard screenshots, and a successful production Worker smoke run; the only source-level concern is visible in CHANGELOG.md. Is this the best way to solve the issue? Mostly yes. Using sweep-status apply_health and a quiet dashboard alert is a narrow, maintainable solution for operator visibility, but the release-owned changelog edit should be removed before merge. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 1343d8ec0cef. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
e2f10a5 to
e58a780
Compare
What Problem This Solves
ClawSweeper now rotates apply batches after #375, but operators still had weak visibility into whether apply was actually progressing or silently stuck on skip-heavy/blocked windows. The live dashboard showed broad fleet health, but not a focused signal for apply lanes that hit the 300-record window, failed live fetches, exhausted runtime budget, or otherwise made no useful pruning progress.
Why This Change Was Made
summarize-apply-reportworkflow utility that turns apply reports into compact health JSON with processed counts, close/comment-sync counts, skip buckets, cursor state, and low-noise attention reasons.pnpm run --silent workflow --so captured files remain valid JSON.Apply ...status has no health payload.openclaw/clawsweeper-statesweep-status files without scanning the open issue/PR universe.User Impact
Maintainers get a visible, targeted alert when pruning progress is blocked or degraded, while normal/idle apply runs remain silent. The alert now says what is blocked, why it matters, and what a maintainer should inspect or run next without turning the dashboard into a noisy metrics dump.
Evidence
git diff --checkpassed.node --test test\dashboard-worker.test.tspassed: 51 passed, 0 failed.pnpm run codex:local:checkpassed after the Codex account reset: local Codex binary found and thegpt-5.5smoke test passed.PNPM_BIN=$env:LOCALAPPDATA\Corepack\shims\pnpm.CMD; pnpm run checkpassed on Windows: 1134 passed, 1 skipped, coverage lane 100%,format:checkall matched files.pnpm run --silent workflow -- summarize-apply-report ... > health.json, thenConvertFrom-Jsonparsedstatus=ok,processed=1,closed=1.dashboard/worker.tsHTML with only/api/statusstubbed: cursor-missing health renders aPruning sweep blockedalert with reason tooltips and a maintainer action to inspect cursor/state publishing;okhealth renders zero alerts and leaves#apply-healthempty.codex.cmd -c service_tier='"fast"' review --uncommittedcompleted with no actionable correctness issues after addressing accepted review findings for silent JSON capture, heartbeat preservation, stale apply-health clearing, cursor-missing guidance, and duplicated skip-count preservation.Screenshot Proof
Problem-focused pruning alert with maintainer action:
Healthy/idle pruning health stays quiet:
Maintainer Rewrite And Live Proof
The contributor design was retained, then rebased onto the current scheduler/apply baseline and repaired across the full apply-result state model.
Exact reviewed head:
b42a805d7c7e312863ac37089309537380b832c2, rebased onto1343d8ec0cef4a5088be01084937fe4396cf9571.Maintainer proof: