fix: preselect Email activity type in edit form#699
Merged
RussH merged 1 commit intoopencats:masterfrom Mar 6, 2026
Merged
Conversation
anonymoususer72041
changed the title
RussH
force-pushed
the
fix/activity-edit-email-type
branch
from
f7d6a97 to
cef4979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editing an existing activity of type "Email", the edit form could incorrectly preselect the first option ("Call"). This happened because the activity list renders the type as "Email" (from
activity_type.short_description), while the edit UI dropdown used the label "E-Mail", causing the preselect matching to fail.This PR aligns the dropdown label with the stored/rendered value and updates the edit preselection logic accordingly.