Fix activity type selection for Email when editing

anonymoususer72041 · anonymoususer72041 · commit f7d6a9701ebc · 2026-01-20T12:00:00.000+01:00
diff --git a/js/activity.js b/js/activity.js
@@ -64,7 +64,7 @@ function Activity_fillTypeSelect(selectList, selectedText)
     /* Email option. */
     optionElements[4] = document.createElement('option');
     optionElements[4].value = ACTIVITY_EMAIL;
-    optionElements[4].appendChild(document.createTextNode('E-Mail'));
+    optionElements[4].appendChild(document.createTextNode('Email'));
 
     /* Meeting option. */
     optionElements[5] = document.createElement('option');
@@ -95,7 +95,7 @@ function Activity_fillTypeSelect(selectList, selectedText)
         {
             optionElements[3].setAttribute('selected', 'selected');
         }
-        else if (selectedText == 'E-Mail')
+        else if (selectedText == 'Email')
         {
             optionElements[4].setAttribute('selected', 'selected');
         }
diff --git a/modules/candidates/AddActivityChangeStatusModal.tpl b/modules/candidates/AddActivityChangeStatusModal.tpl
@@ -125,7 +125,7 @@
                             <option value="<?php echo(ACTIVITY_CALL_TALKED); ?>">Call (Talked)</option>
                             <option value="<?php echo(ACTIVITY_CALL_LVM); ?>">Call (LVM)</option>
                             <option value="<?php echo(ACTIVITY_CALL_MISSED); ?>">Call (Missed)</option>
-                            <option value="<?php echo(ACTIVITY_EMAIL); ?>">E-Mail</option>
+                            <option value="<?php echo(ACTIVITY_EMAIL); ?>">Email</option>
                             <option value="<?php echo(ACTIVITY_MEETING); ?>">Meeting</option>
                             <option value="<?php echo(ACTIVITY_OTHER); ?>">Other</option>
                         </select><br />
diff --git a/modules/contacts/AddActivityScheduleEventModal.tpl b/modules/contacts/AddActivityScheduleEventModal.tpl
@@ -44,7 +44,7 @@
                             <option value="<?php echo(ACTIVITY_CALL_TALKED); ?>">Call (Talked)</option>
                             <option value="<?php echo(ACTIVITY_CALL_LVM); ?>">Call (LVM)</option>
                             <option value="<?php echo(ACTIVITY_CALL_MISSED); ?>">Call (Missed)</option>
-                            <option value="<?php echo(ACTIVITY_EMAIL); ?>">E-Mail</option>
+                            <option value="<?php echo(ACTIVITY_EMAIL); ?>">Email</option>
                             <option value="<?php echo(ACTIVITY_MEETING); ?>">Meeting</option>
                             <option value="<?php echo(ACTIVITY_OTHER); ?>">Other</option>
                         </select><br />

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ function Activity_fillTypeSelect(selectList, selectedText)`
`64`	`64`	`/* Email option. */`
`65`	`65`	`optionElements[4] = document.createElement('option');`
`66`	`66`	`optionElements[4].value = ACTIVITY_EMAIL;`
`67`		`- optionElements[4].appendChild(document.createTextNode('E-Mail'));`
	`67`	`+ optionElements[4].appendChild(document.createTextNode('Email'));`
`68`	`68`
`69`	`69`	`/* Meeting option. */`
`70`	`70`	`optionElements[5] = document.createElement('option');`
`@@ -95,7 +95,7 @@ function Activity_fillTypeSelect(selectList, selectedText)`
`95`	`95`	`{`
`96`	`96`	`optionElements[3].setAttribute('selected', 'selected');`
`97`	`97`	`}`
`98`		`- else if (selectedText == 'E-Mail')`
	`98`	`+ else if (selectedText == 'Email')`
`99`	`99`	`{`
`100`	`100`	`optionElements[4].setAttribute('selected', 'selected');`
`101`	`101`	`}`