Skip to content

fix: validate list-valued agent outputs - #134

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/fix-agent-output-lists
Sep 24, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
codex/fix-agent-output-lists

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

This pull request fixes list-valued agent outputs being treated as conversation history instead of generated content. Output checks now receive the text of every top-level list item, preserving literal characters within string items and leaving the original returned output unchanged.

Input conversation extraction and non-list output handling remain unchanged. Regression coverage exercises the real Agents SDK runner with mocked provider responses under both strict and default error handling.

Validation: two independent reviews; formatting, Ruff, mypy, and pyright passed; 1,596 pytest tests and four release-workflow tests passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T12:25:24.140568Z 6286fd0 New commits
🔒 Security Review ✅ Completed 2026-09-24T12:27:19.330077Z 6286fd0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 213da72 against the released Agents output contract and the existing guardrail adapter. No actionable correctness or structural findings: generated lists now pass all top-level items through the existing text-check policy, while input history, non-list handling, literal string contents, and returned output values remain intact. The focused real-SDK regression coverage exercises both blocked output and unchanged safe results.

Source-only review; all eight checks on this head passed (Python 3.11–3.14 and CodeQL). I did not rerun tests locally.

@jbeckwith-oai
jbeckwith-oai force-pushed the codex/fix-agent-output-lists branch from 213da72 to 6286fd0 Compare September 24, 2026 12:23
@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit 8913470 Sep 24, 2026
8 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/fix-agent-output-lists branch September 24, 2026 12:32
@openai-sdks openai-sdks Bot mentioned this pull request Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants